From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F010CCA479 for ; Thu, 7 Jul 2022 13:41:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235932AbiGGNlI (ORCPT ); Thu, 7 Jul 2022 09:41:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235844AbiGGNlH (ORCPT ); Thu, 7 Jul 2022 09:41:07 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6C2528E35 for ; Thu, 7 Jul 2022 06:41:05 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id w2so5946691ljj.7 for ; Thu, 07 Jul 2022 06:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=jRAjZXY6+UUMfN9anTAWHy/uwmogMIm8H3PLiHy9OEI=; b=nNBRS+FZwsMAmv+unQDonMckzxWyz51mGvxoj5yAx5CBRCb1ZAlNEP4YGf0HIQB7Jj xzLlWnvMnTQ1LsabcoJH6BEzf6slgc8cjTwSn4KkCm5lOW03zo8juX8AwcwOee9RhnNk 8KHlFFAjDimv0YupF2OA6QTJ/yN77Tvq7WkMyQ4J0BCduoT64mvaVfGlog1xQrLUtizz te475qDsuU8gJFcRQMiMsg/dtTOvhJw+7w1YHNyg1Jhn0LA5Wi8LqgxdNRCA5xk47Xqc zJDU7HtTYt9HT6oaIv0wukY83stC9PGpul9zEL08tkFJErE+t1GlpOS5tYIStKOwWzHk oK6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=jRAjZXY6+UUMfN9anTAWHy/uwmogMIm8H3PLiHy9OEI=; b=rl+8QX7qxl70oBRR3GxT7aMRMXpmwFpjVPkJXEMTU/26ak6E8D8d/hvrIeZi5XkXJl pbqzyC+zsWJUjyDKv4XVTkyfeQa7IAalaennvkfEbZqzpkMrVNbRfjgCav4opacHAz2T jqKr3zN1ouGwr4+044edhIIlPKg611293sAZmGshMawsH5OfJbbCq5O0hsez/2trzfAN 3hzc7VBMG4722WwqaZqKN0giTNj+5JMkm4/uJJ/zWzuJS0uQIPRddPWa7d1CgqZsjYjc Ag4VI3wcdhbdtJz7+7u0rYdPg7ZPL738nlsd3kwIbaVpa7t2zCoivMElSoWmvgyJpB8i A4kA== X-Gm-Message-State: AJIora+BODgmFx0PO/hZKVhyn2ZeArdYir+i4oUpSKWaBdPQJBPNwHJD QR9tLB+pMf95HoHAscs3cxf89g== X-Google-Smtp-Source: AGRyM1t4UqVaNKTbjrPlQkcNgoKuyx+oGPkBeDq++hP317Wk1kHIWC4XtoISid7vnJuGGeLqCFO/dQ== X-Received: by 2002:a2e:92c6:0:b0:255:84cb:4eea with SMTP id k6-20020a2e92c6000000b0025584cb4eeamr25815297ljh.204.1657201264047; Thu, 07 Jul 2022 06:41:04 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id e20-20020a05651c04d400b0025a64093a9esm6794026lji.117.2022.07.07.06.41.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 06:41:03 -0700 (PDT) Message-ID: <2fbe9cf7-7ed8-ccc8-b0bc-26d358cec927@linaro.org> Date: Thu, 7 Jul 2022 16:41:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 02/10] dt-bindings: PCI: qcom: Fix msi-interrupt conditional Content-Language: en-GB From: Dmitry Baryshkov To: Johan Hovold , Bjorn Helgaas , Lorenzo Pieralisi Cc: Rob Herring , Krzysztof Kozlowski , Stanimir Varbanov , Andy Gross , Bjorn Andersson , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220629141000.18111-1-johan+linaro@kernel.org> <20220629141000.18111-3-johan+linaro@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/07/2022 16:34, Dmitry Baryshkov wrote: > On 29/06/2022 17:09, Johan Hovold wrote: >> Fix the msi-interrupt conditional which always evaluated to false due to >> a misspelled property name ("compatibles" in plural). >> >> Signed-off-by: Johan Hovold > > Fixes: 6700a9b00f0a ("dt-bindings: PCI: qcom: Do not require resets on > msm8996 platforms") Ugh, I was thinking about a different chunk (which also has this issue), so please ignore the Fixes. > Reviewed-by: Dmitry Baryshkov > > >> --- >>   Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index ed9f9462a758..a1b4fc70e162 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -628,7 +628,7 @@ allOf: >>       # On older chipsets it's always 1 msi interrupt >>     - if: >>         properties: >> -        compatibles: >> +        compatible: >>             contains: >>               enum: >>                 - qcom,pcie-msm8996 > > -- With best wishes Dmitry