From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chancel Liu <chancel.liu@nxp.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [RESEND v2 3/3] ASoC: dt-bindings: fsl,mqs: Convert format to json-schema
Date: Mon, 20 Nov 2023 10:38:40 +0100 [thread overview]
Message-ID: <2fec766b-dd75-4b96-8114-394ff16c63a7@linaro.org> (raw)
In-Reply-To: <20231120084905.664-4-chancel.liu@nxp.com>
On 20/11/2023 09:49, Chancel Liu wrote:
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: fsl,imx8qm-mqs
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Master clock
> + - description: Clock for register access
> + clock-names:
> + items:
> + - const: mclk
> + - const: core
> + required:
> + - reg
> + - power-domains
> + else:
> + properties:
> + clocks:
> + items:
> + - description: Master clock
> + clock-names:
> + items:
> + - const: mclk
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx6sx-mqs
> + - fsl,imx93-mqs
> + then:
> + required:
> + - gpr
This is a bit confusing. Only "fsl,imx8qm-mqs" requires (uses?) reg.
imx6sx and imx93 use gpr. Then what do the other variants use?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-20 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 8:49 [RESEND v2 0/3] Add audio device nodes for i.MX93 platform Chancel Liu
2023-11-20 8:49 ` [RESEND v2 1/3] arm64: dts: imx93: Add audio device nodes Chancel Liu
2023-11-20 8:49 ` [RESEND v2 2/3] arm64: dts: imx93: Configure clock rate for audio PLL Chancel Liu
2023-11-20 8:49 ` [RESEND v2 3/3] ASoC: dt-bindings: fsl,mqs: Convert format to json-schema Chancel Liu
2023-11-20 9:38 ` Krzysztof Kozlowski [this message]
2023-11-21 6:08 ` Chancel Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fec766b-dd75-4b96-8114-394ff16c63a7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chancel.liu@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).