From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: ChiYuan Huang <cy_huang@richtek.com>
Cc: broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com,
u0084500@gmail.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek RT5739
Date: Thu, 16 Feb 2023 11:45:05 +0100 [thread overview]
Message-ID: <2fecab8a-26ae-c62d-bf47-7319e11bbe51@linaro.org> (raw)
In-Reply-To: <20230216103530.GA17387@linuxcarl2.richtek.com>
On 16/02/2023 11:35, ChiYuan Huang wrote:
> https://elixir.bootlin.com/linux/v6.2-rc8/source/drivers/regulator/of_regulator.c#L198
> It seems no need to limit the maxItems. Regulator core will call 'of_map_mode' to check the value.
> Even the value is repeat.
>
> And for minItems, 'regulator.yaml' already said it's uint32-array. Must be lager than zero, right?
>
> So how about just keep 'items' and remove the 'maxItems'?
Yeah, go ahead, with that enum, it should be correct..
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-16 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 2:00 [PATCH 0/2] Add Richtek RT5739 switching voltage regulator support cy_huang
2023-02-15 2:00 ` [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek RT5739 cy_huang
2023-02-15 13:03 ` Mark Brown
2023-02-15 13:30 ` ChiYuan Huang
2023-02-16 9:12 ` Krzysztof Kozlowski
2023-02-16 9:57 ` ChiYuan Huang
2023-02-16 10:03 ` Krzysztof Kozlowski
2023-02-16 10:35 ` ChiYuan Huang
2023-02-16 10:45 ` Krzysztof Kozlowski [this message]
2023-02-15 2:00 ` [PATCH 2/2] regulator: Add support for Richtek RT5739 voltage regulator cy_huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fecab8a-26ae-c62d-bf47-7319e11bbe51@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).