From: Heiko Stuebner <heiko@sntech.de>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
briannorris@chromium.org, hoegsberg@gmail.com,
philippe.cornu@st.com, dri-devel@lists.freedesktop.org,
yannick.fertre@st.com, linux-rockchip@lists.infradead.org,
nickey.yang@rock-chips.com, robh+dt@kernel.org,
thierry.reding@gmail.com, laurent.pinchart@ideasonboard.com,
seanpaul@chromium.org, mka@chromium.org
Subject: Re: [PATCH v4 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup
Date: Tue, 21 Aug 2018 15:56:59 +0200 [thread overview]
Message-ID: <3000898.fNWOa9lLO7@phil> (raw)
In-Reply-To: <20180820113726eucas1p229037428a6ac9cee0bd85b6a46074a94~MlK2T-2GX2929829298eucas1p29@eucas1p2.samsung.com>
Hi Andrzej,
Am Montag, 20. August 2018, 13:37:24 CEST schrieb Andrzej Hajda:
> On 14.08.2018 12:26, Heiko Stuebner wrote:
> > >From a specified output port of one dsi controller this function allows to
> > iterate over the list of registered dsi controllers trying to find a second
> > instance connected to the same display, like it is used in dual-dsi setups.
>
> As I said earlier it looks for me incorrectly. You create helper to
> access/control one DSI controller from another but there is no point in
> doing it. If CRTC is able to send video stream via two links it should
> be CRTC's responsibility to setup and use DSI controllers attached to
> these links. If the panel is able to combine stream from two DSI links
> into one image it should be panel's responsibility to inform DSI
> controllers about each link's configuration.
>
> Moreover from usage of this helper (patch 8/8) it looks like you
> assumes, that second host must be also synopsys, this is not
> true/generic at all.
>
> I know there could be many obstacles in alternative approach, so you
> really insist on this hack, please use it inside the driver, you can use
> for example driver_for_each_device/driver_find_device to find 2nd DSI host.
Ok, I'll move that inside the rockchip-driver.
My rationale still is that both msm (with a Committer-Signed-off by Rob
Clark) and Tegra (code from Thierry), do follow the expectation of two
controllers of the same type) ... people doing graphics stuff way longer
than me. So I'd like to believe the valid issue you are raising will have
been discussed at least two times already ;-) .
So I really prefer not to open that can of worms myself if I don't have
to ;-) .
Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-21 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 10:26 [PATCH v4 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi Heiko Stuebner
[not found] ` <20180814102654.29113-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2018-08-14 10:26 ` [PATCH v4 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove Heiko Stuebner
2018-08-14 10:26 ` [PATCH v4 3/8] drm/bridge/synopsys: dsi: add ability to have glue-specific attach and detach Heiko Stuebner
[not found] ` <20180814102654.29113-4-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2018-08-20 10:34 ` Andrzej Hajda
2018-08-21 13:49 ` Heiko Stuebner
2018-08-14 10:26 ` [PATCH v4 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind Heiko Stuebner
2018-08-14 10:26 ` [PATCH v4 4/8] dt-bindings: display: rockchip: update DSI controller Heiko Stuebner
2018-08-14 10:26 ` [PATCH v4 5/8] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver Heiko Stuebner
[not found] ` <20180814102654.29113-6-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2018-08-20 11:01 ` Andrzej Hajda
2018-08-14 10:26 ` [PATCH v4 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup Heiko Stuebner
2018-08-20 11:37 ` Andrzej Hajda
2018-08-21 13:56 ` Heiko Stuebner [this message]
2018-08-14 10:26 ` [PATCH v4 7/8] drm/bridge/synopsys: dsi: add dual-dsi support Heiko Stuebner
2018-08-14 10:26 ` [PATCH v4 8/8] drm/rockchip: dsi: add dual mipi support Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3000898.fNWOa9lLO7@phil \
--to=heiko@sntech.de \
--cc=a.hajda@samsung.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegsberg@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=nickey.yang@rock-chips.com \
--cc=philippe.cornu@st.com \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).