devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gokul Praveen <g-praveen@ti.com>,
	j-keerthy@ti.com, vigneshr@ti.com, wbg@kernel.org,
	linux-kernel@vger.kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org
Cc: u-kumar1@ti.com, n-francis@ti.com
Subject: Re: [PATCH 1/2] dt-bindings: counter: Add new ti,omap-dmtimer-cap compatible
Date: Tue, 7 Oct 2025 15:35:28 +0900	[thread overview]
Message-ID: <30101fb9-e2eb-4050-896a-7be629ced44d@kernel.org> (raw)
In-Reply-To: <9653740a-44fe-46bb-92c8-f7fc26cbe5ee@ti.com>

On 26/09/2025 18:06, Gokul Praveen wrote:
>>
>>> +
>>> +  ti,timers:
>>> +    description: Timer instance phandle for the Capture
>>
>> So the only resource is phandle? That's completely fake device then. NAK.
>>
> 
> 
> The OMAP Timer IP can operate in 3 modes: Timer, PWM mode or capture
> (mutually exclusive).
> The timer/ti,timer-dm.yaml file describes the timer mode of operation.
> It encapsulates base IP block and reg property is also part the same
> binding.
> 
> This node represents the capture mode with phandle reference to the
> timer DT node. This is modeled all the same lines as how PWM
> functionality is implemented in pwm/ti,omap-dmtimer-pwm.yaml

Different modes do not have their own device nodes. It is still one
device, so one device node.

> 
> Now, if this needs to change, please suggest alternate.
> 
> One solution is perhaps to add a new property to ti,timer-dm.yaml itself
> to indicate the mode of IP?

Not sure, depends what this really is and how it is used. I can also
imagine that consumer defines the mod of operation.

Or mode of operation could be even configured runtime, thus not suitable
for DT at all.

Best regards,
Krzysztof

  reply	other threads:[~2025-10-07  6:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  8:00 [PATCH 0/2] Capture driver support for OMAP DM timer Gokul Praveen
2025-09-09  8:00 ` [PATCH 1/2] dt-bindings: counter: Add new ti,omap-dmtimer-cap compatible Gokul Praveen
2025-09-10  7:08   ` Krzysztof Kozlowski
2025-09-26  9:06     ` Gokul Praveen
2025-10-07  6:35       ` Krzysztof Kozlowski [this message]
2025-10-07  9:23         ` Gokul Praveen
2025-10-07  9:39           ` Krzysztof Kozlowski
2025-10-07  9:49             ` Gokul Praveen
2025-10-07 14:32               ` Krzysztof Kozlowski
2025-09-09  8:00 ` [PATCH 2/2] counter: ti-dmtimer-cap : capture driver support for OMAP DM timer Gokul Praveen
2025-09-09 14:58   ` Andrew Davis
2025-09-10  6:39   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30101fb9-e2eb-4050-896a-7be629ced44d@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=g-praveen@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n-francis@ti.com \
    --cc=robh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    --cc=wbg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).