From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Fricke <sebastian.fricke@collabora.com>
Cc: linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
kernel@collabora.com, bob.beckett@collabora.com,
hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com,
nas.chung@chipsnmedia.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 5/6] dt-bindings: media: wave5: add yaml devicetree bindings
Date: Wed, 7 Dec 2022 16:27:56 +0100 [thread overview]
Message-ID: <30166f9d-ebfa-ed8b-c08b-ff8e2599161f@linaro.org> (raw)
In-Reply-To: <20221207150925.frotwpm3ukwwlnig@basti-XPS-13-9310>
On 07/12/2022 16:09, Sebastian Fricke wrote:
> Hello Krzysztof,
>
> On 07.12.2022 13:31, Krzysztof Kozlowski wrote:
>> On 07/12/2022 13:13, Sebastian Fricke wrote:
>>> From: Robert Beckett <bob.beckett@collabora.com>
>>>
>>> Add bindings for the wave5 chips&media codec driver
>>>
>>> Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
>>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>>> Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
>>
>> What's happening with this patch? Where is the changelog?
>
> The changelog is located in the cover letter.
> https://lore.kernel.org/linux-media/20221207121350.66217-1-sebastian.fricke@collabora.com/
Which you did not sent to us... so? How does it help us?
>
>> Why it is v11 and first time I see it?
>
> You actually replied to V10:
> https://lore.kernel.org/linux-media/20221023085341.s23qinjuw4qls3dn@basti-XPS-13-9310/
>
>> And why it is v11 with basic mistakes and lack of testing?!?
>> I would assume that v11 was already seen and tested...
>
> Sorry I don't have a lot of experience with dt-bindings, thank you for
> highlighting the issues, I will correct them. And I forgot to build the
> documentation during my testing runs.
> I took over the patch set from another contributor and as no one
> complained about the dt-bindings for the last 10 versions, I concentrated
> my energy on other problems.
Because they were never sent to maintainers...
>
>>
>>
>>> ---
>>> .../devicetree/bindings/cnm,wave5.yml | 72 +++++++++++++++++++
>>> 1 file changed, 72 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/cnm,wave5.yml
>>
>> Wrong directory. It wasn't here at all before, so I am really confused
>> how this could happen.
>
> Thanks for the highlight.
>
> I will move it to:
> Documentation/devicetree/bindings/media/cnm,wave5.yml
>
>>
>> Subject: drop redundant pieces: yaml, devicetree and bindings.
>
> I call it:
>
> dt-bindings: media: chips-media: add wave5 bindings
>
> in V12
>
> Sincerely,
> Sebastian Fricke
And the rest questions? Lack of response means agreement, which is fine,
so in v12 questionable parts will be removed?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-07 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221207121350.66217-1-sebastian.fricke@collabora.com>
2022-12-07 12:13 ` [PATCH v11 5/6] dt-bindings: media: wave5: add yaml devicetree bindings Sebastian Fricke
2022-12-07 12:31 ` Krzysztof Kozlowski
2022-12-07 13:17 ` Krzysztof Kozlowski
2022-12-07 15:09 ` Sebastian Fricke
2022-12-07 15:27 ` Krzysztof Kozlowski [this message]
2022-12-12 11:32 ` Sebastian Fricke
2023-09-04 6:25 ` Sebastian Fricke
2023-09-04 7:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30166f9d-ebfa-ed8b-c08b-ff8e2599161f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bob.beckett@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nas.chung@chipsnmedia.com \
--cc=nicolas.dufresne@collabora.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.fricke@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).