From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: dianders@chromium.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: sc7180: Add sku_id and board id for lazor/limozeen
Date: Tue, 22 Aug 2023 16:34:25 +0200 [thread overview]
Message-ID: <3021b5bb-a88b-4427-b6ee-3dde216fc6b3@linaro.org> (raw)
In-Reply-To: <20230822180054.v5.2.I8f20fdfe34a2e8a38373bbd65587754b324f3dcb@changeid>
On 22.08.2023 12:03, Sheng-Liang Pan wrote:
> SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0)
> SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0)
> SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0)
>
> Even though the "no esim" boards are strapped differently than
> ones that have an esim, the esim isn't represented in the
> device tree so the same device tree can be used for LTE w/ esim
> and LTE w/out esim.
>
> add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
Minor style nits since Doug already suggested a v6:
- please add a space between /delete-node/ and the &reference after it
- keep properties (e.g. pinctrl-) like this:
property-n
property-names
Konrad
next prev parent reply other threads:[~2023-08-22 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 10:03 [PATCH v5 0/2] Add no-esim sku for sc7180-lazor family and new board version for audio codec ALC5682i-VS Sheng-Liang Pan
2023-08-22 10:03 ` [PATCH v5 1/2] dt-bindings: arm: qcom: add sc7180-lazor board bindings Sheng-Liang Pan
2023-08-22 13:41 ` Doug Anderson
2023-08-22 10:03 ` [PATCH v5 2/2] arm64: dts: qcom: sc7180: Add sku_id and board id for lazor/limozeen Sheng-Liang Pan
2023-08-22 14:13 ` Doug Anderson
2023-08-23 8:13 ` Sheng-Liang Pan
2023-08-22 14:34 ` Konrad Dybcio [this message]
2023-08-23 8:07 ` Sheng-Liang Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3021b5bb-a88b-4427-b6ee-3dde216fc6b3@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sheng-liang.pan@quanta.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).