From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF57EE4993 for ; Tue, 22 Aug 2023 14:34:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234971AbjHVOeb (ORCPT ); Tue, 22 Aug 2023 10:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233587AbjHVOea (ORCPT ); Tue, 22 Aug 2023 10:34:30 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A9AF93 for ; Tue, 22 Aug 2023 07:34:29 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fe11652b64so6964676e87.0 for ; Tue, 22 Aug 2023 07:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692714867; x=1693319667; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1eMxUkD/XA8Y8AaTxvT5+HCWHgKw5NUwvOAq4hpjS84=; b=ahbk5Q/vF0mlmcBRa5TPIMBwEunswPzkKjJi8n8aZFrTNFt7uRzc6JB0bpm9Y4BPHp s2JE5qjHWU3uhz19AMX5pf27HPidB4/SQnM/lI7rczCZQyxR/elaq9bxWUR9f8EL7L8y /zW8dC1ryGq+7cwGlVaAHjRsx0qzUOni7NSzS4o43ljJlWMQcQaF2i5ul/PXWm6NjmK1 BVwzPd8cZjutcK/0aIudUaHEFznhOfXkz8dKo+nvIhQtJcOmEb2BX9o0q+wiIbqy7rZA pIo6n3LsW6iyfeskgrtT6JOIQ9Hh/qEOsKzqqaO71RlgKbb+DUm8TA9K9lCRZWq/KZh4 a12Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692714867; x=1693319667; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1eMxUkD/XA8Y8AaTxvT5+HCWHgKw5NUwvOAq4hpjS84=; b=fvicuH947LQdeeNaCBsZuWLL63QM7HnUyqYE873TXXY/c3SD9cumuhRrFVY32Gq6FL qzK2vWwImV6ZbfD011CEcunqmswpyZUpYE3P1s/wcg8rNg78ROc4VGrbiSzhyG1/AKta efdsYQH3FcUSpe35XR1d6iBKpC7ddxHppn0+SyFawl34DlQekfAaYhBBfR3kFB7PCn4f tozWN2isryR4SkwjhS68CFmMOssGuqghZcl/OwueLI+msj4BK2yP6IshuFAOrw9resKL ZNsS/gDU4MVUWFsBtC1/+YEI9eucTFnFtu7NxlDYQZdod+aUEAZZORvic6ECnwJ/kYj1 VN8g== X-Gm-Message-State: AOJu0Yy3zG7hrCQwFktS7AKxXBPj9j3NGmK2XMJp9/vl7pV9WjWkJYoX 7ciDFEQ3RrQY1b1wxILqDNn1XWFtrMM0bAOIGKoG3g== X-Google-Smtp-Source: AGHT+IG/CLwIIK85FrrG+V0Cren34Lcs6dLtCZ5E4IViI93u20QeqW8530d2LH++mcO7ajs4z7YsQw== X-Received: by 2002:a05:6512:31c8:b0:4fb:91c5:fd38 with SMTP id j8-20020a05651231c800b004fb91c5fd38mr8760041lfe.0.1692714867368; Tue, 22 Aug 2023 07:34:27 -0700 (PDT) Received: from [192.168.1.101] (abyk189.neoplus.adsl.tpnet.pl. [83.9.30.189]) by smtp.gmail.com with ESMTPSA id y11-20020ac255ab000000b004f764716afdsm2228181lfg.257.2023.08.22.07.34.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 07:34:27 -0700 (PDT) Message-ID: <3021b5bb-a88b-4427-b6ee-3dde216fc6b3@linaro.org> Date: Tue, 22 Aug 2023 16:34:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: sc7180: Add sku_id and board id for lazor/limozeen Content-Language: en-US To: Sheng-Liang Pan , LKML Cc: dianders@chromium.org, Andy Gross , Bjorn Andersson , Conor Dooley , Krzysztof Kozlowski , Rob Herring , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230822100359.124282-1-sheng-liang.pan@quanta.corp-partner.google.com> <20230822180054.v5.2.I8f20fdfe34a2e8a38373bbd65587754b324f3dcb@changeid> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20230822180054.v5.2.I8f20fdfe34a2e8a38373bbd65587754b324f3dcb@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22.08.2023 12:03, Sheng-Liang Pan wrote: > SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0) > SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0) > SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0) > > Even though the "no esim" boards are strapped differently than > ones that have an esim, the esim isn't represented in the > device tree so the same device tree can be used for LTE w/ esim > and LTE w/out esim. > > add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS > > Signed-off-by: Sheng-Liang Pan > --- Minor style nits since Doug already suggested a v6: - please add a space between /delete-node/ and the &reference after it - keep properties (e.g. pinctrl-) like this: property-n property-names Konrad