public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Jonathan Santos <Jonathan.Santos@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
	marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	marcelo.schmitt1@gmail.com, linus.walleij@linaro.org,
	brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org,
	jonath4nns@gmail.com
Subject: Re: [PATCH v5 02/14] dt-bindings: iio: adc: ad7768-1: add trigger-sources property
Date: Fri, 11 Apr 2025 16:57:08 -0500	[thread overview]
Message-ID: <3027a9b0-cf4a-4e55-80a7-7f0dd2a008e4@baylibre.com> (raw)
In-Reply-To: <35481552e9ce39a24a0257ab001c0bcfea1a23be.1744325346.git.Jonathan.Santos@analog.com>

On 4/11/25 10:56 AM, Jonathan Santos wrote:
> In addition to GPIO synchronization, The AD7768-1 also supports
> synchronization over SPI, which use is recommended when the GPIO
> cannot provide a pulse synchronous with the base MCLK signal. It
> consists of looping back the SYNC_OUT to the SYNC_IN pin and send
> a command via SPI to trigger the synchronization.
> 
> Introduce the 'trigger-sources' property to support SPI-based
> synchronization, along with additional optional entries for the SPI
> offload trigger and the START signal via GPIO3.
> 
> While at it, add description to the interrupts property.
> 
> Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
> ---

...

> @@ -57,6 +80,15 @@ properties:
>    "#io-channel-cells":
>      const: 1
>  
> +  "#trigger-source-cells":
> +    description: |
> +      Indicates the trigger source type for each entry:
> +      0 = Synchronization GPIO-based trigger
> +      1 = Synchronization device trigger (e.g., another ad7768-1)
> +      2 = GPIO3 pin acting as START signal
> +      3 = DRDY pin acting as SPI offload trigger
> +    const: 1
> +

0 and 1 don't sound like trigger outputs that this ADC is providing, so don't
seem appropriate here. But the SYNC_OUT pin is missing from this list.

Also, outputs could be used to trigger anything, not just SPI offload, so don't
need to mention that.

  parent reply	other threads:[~2025-04-11 21:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11 15:55 [PATCH v5 00/14] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-04-11 15:56 ` [PATCH v5 01/14] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-04-11 16:41   ` Conor Dooley
2025-04-11 21:49   ` David Lechner
2025-04-16  7:43   ` Linus Walleij
2025-04-16 18:38     ` David Lechner
2025-04-11 15:56 ` [PATCH v5 02/14] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-04-11 16:30   ` Conor Dooley
2025-04-11 21:27   ` David Lechner
2025-04-17  0:08     ` Jonathan Santos
2025-04-17 15:11       ` David Lechner
2025-04-11 21:57   ` David Lechner [this message]
2025-04-17  0:22     ` Jonathan Santos
2025-04-17 15:07       ` David Lechner
2025-04-11 15:56 ` [PATCH v5 03/14] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-04-11 15:56 ` [PATCH v5 04/14] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-04-11 15:56 ` [PATCH v5 05/14] iio: adc: ad7768-1: convert driver to use regmap Jonathan Santos
2025-04-12 17:51   ` Jonathan Cameron
2025-04-11 15:57 ` [PATCH v5 06/14] iio: adc: ad7768-1: Add reset gpio Jonathan Santos
2025-04-12 17:52   ` Jonathan Cameron
2025-04-11 15:57 ` [PATCH v5 07/14] iio: adc: ad7768-1: Move buffer allocation to a separate function Jonathan Santos
2025-04-12 17:54   ` Jonathan Cameron
2025-04-11 15:57 ` [PATCH v5 08/14] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-04-11 21:44   ` David Lechner
2025-04-12 18:02   ` Jonathan Cameron
2025-04-11 15:57 ` [PATCH v5 09/14] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-04-16  7:35   ` Linus Walleij
2025-04-11 15:58 ` [PATCH v5 10/14] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-04-11 15:58 ` [PATCH v5 11/14] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-04-11 22:48   ` David Lechner
2025-04-11 15:58 ` [PATCH v5 12/14] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-04-11 15:58 ` [PATCH v5 13/14] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-04-11 23:26   ` David Lechner
2025-04-12 18:11   ` Jonathan Cameron
2025-04-11 15:59 ` [PATCH v5 14/14] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3027a9b0-cf4a-4e55-80a7-7f0dd2a008e4@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=Jonathan.Santos@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=jonath4nns@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox