From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB2D3298CD1 for ; Fri, 11 Apr 2025 21:57:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744408635; cv=none; b=Iik7A12pOk30e/B6rSIZqxijion431iCNGhQAfBocQahOWMR2OP82rCONNqL2xX4wnxiCsyO0riNfe+DA84nNBY581cOagkSQGd0Qm1Wq9rmM2TEx4k7KzZTzh0Sof3b7/doOV6S7QuWq/t3FhYe2GFVymQ13+vdo6Ebitn1zyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744408635; c=relaxed/simple; bh=U/5OSHIm4xidi8WZpyCWBuRqvMGUXBR//iyTnMoWcNA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bh3CsFhl5CxKA6qeBZrOf0EadmhxyfPohci6yFirlnOhxN7BEcxvHb0rZeHgLmiw5VZ85Zks8wm/GsFkot4Jxfolr+yBvSXJZtCRUVFj4lSRldrBzqWwJ4Ribq1+0yl81qTu2s2HzjBbgUhJgpIr3KQErMSVPsReWXXRGTRKclA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=M6dr6Jbo; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="M6dr6Jbo" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-72bceb93f2fso1865856a34.0 for ; Fri, 11 Apr 2025 14:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1744408632; x=1745013432; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hGxgbzS8SsXJLi5EFV0c4NWHcpynG76/jsFGgon3TKI=; b=M6dr6Jbo7oVS8NsgNlCn2EguipsGDH9H50oBIxFxjAr2bh3JnWasNuTJv1AxkFTXfW wW9ke+3WzhjlrvUPLqip92zDQnEylA7TyYXpVOAvkvPdrecqxToTDOBBWn3YDsVugdBM qjegjBZ6JAfYQ2hb9UwjGJd63z//gobAM2zNdIo1VSUNp7Sb1Z4Y4ekfDo07v4YNC+a8 NkfDxkhUVLS3VC8rblHwI4hwSHfECa2TrLUY68IbhOQVnc2Rgssn7N5UIeE/1Fqs7Vr1 13qeE8fs1DYcsdDeqpfehtdJSSNbB0g0Qon9CzeMTWVun/ixOjOwv+/9KKIkWuo7hTHm q4jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744408632; x=1745013432; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hGxgbzS8SsXJLi5EFV0c4NWHcpynG76/jsFGgon3TKI=; b=AjPlqPdhobymUfU2mdH4tYsQYeRFWAX14QxGXA2sY00RlLULM6R5FUVNjtPjzK5aev Vo8mha5DbjIUZgCbmh9Gl7rVRmBui6rBBy9TrZN7sOR5eJK1qHwujtpPp8a+DXVsXjaG om9rBzQqbUxH4K5l05t0KhDjOvAIRE/uULn2s8Gn6EWo0CvDjGBa0FFeHjI++b/zzHQr CNDb6DH/THt97v6cslpsemMT6P3286VMw3SadJ3NPJ4tNV/TDouMznaRkLXca4tFROgt pGE48wCIzzRljFtSczz6MXalzefU2PTcXVI2O/z09AdO7rRA0/LA/Mcwl9JR4PIoeZhu 4wUg== X-Forwarded-Encrypted: i=1; AJvYcCWOGzBHYSK1swQDHyyGA0IZxEnXQ01Kb8y9af2itQX52meqdYVRkIXWja5sQjOhRIju3crJwHpN1Rzd@vger.kernel.org X-Gm-Message-State: AOJu0YzTuOpS1iymZQtKYYJ83nhBsV08UJuwGZCfRrkuupHrvPr0pPVQ mnQu/91iOCf1H0Fh+gE2iEwmO3em2kd48gVSrakSvK2oLNWmR8Mx/vEdl5tGKvA= X-Gm-Gg: ASbGncuoKgN5Y/paVWVVjuvtufxSlduHDUPsxX52LmSxjKb1CnVjtZkVJe1EB7DIc9Z JWpnHV7D1x3TbPc58sm0h/C0dJDf6uHtflnOGzUNEnwGz3YblpOFdZFkMl4vBkf811LoQMCsnJZ SJli2ukolS8Me+Dh6oK9eCYjycPM/hrePOcxT/Jw95uoFfF2rtLkAUIdEWRKW7pRPxwRZEUouY5 fiaOtzmL3MfrIVT2GGquyumgQomQruR2ipEkX4BbYM+QTpAycFBiEfpNWopFMCdAfFgEuFi0xDY eR0AcwjnkkC0uI8I4Eazggg07QhEgr/7dtM6jShBw7dy+vxSnJFEWhYMgrffaFZoz+nvo19gc1j Sh23Yiwihd9uV X-Google-Smtp-Source: AGHT+IHJ8jsSgRFDtzkrcSxyEZnKdBoL/URDBhhkNCEX69zyJiLizO+9RyTuZoOivQHbrnufomIfTQ== X-Received: by 2002:a05:6808:17aa:b0:3f9:176a:3958 with SMTP id 5614622812f47-4007bfe4d70mr4807862b6e.11.1744408631784; Fri, 11 Apr 2025 14:57:11 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6045f5b295bsm1073636eaf.35.2025.04.11.14.57.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 14:57:10 -0700 (PDT) Message-ID: <3027a9b0-cf4a-4e55-80a7-7f0dd2a008e4@baylibre.com> Date: Fri, 11 Apr 2025 16:57:08 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/14] dt-bindings: iio: adc: ad7768-1: add trigger-sources property To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com, linus.walleij@linaro.org, brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org, jonath4nns@gmail.com References: <35481552e9ce39a24a0257ab001c0bcfea1a23be.1744325346.git.Jonathan.Santos@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <35481552e9ce39a24a0257ab001c0bcfea1a23be.1744325346.git.Jonathan.Santos@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/11/25 10:56 AM, Jonathan Santos wrote: > In addition to GPIO synchronization, The AD7768-1 also supports > synchronization over SPI, which use is recommended when the GPIO > cannot provide a pulse synchronous with the base MCLK signal. It > consists of looping back the SYNC_OUT to the SYNC_IN pin and send > a command via SPI to trigger the synchronization. > > Introduce the 'trigger-sources' property to support SPI-based > synchronization, along with additional optional entries for the SPI > offload trigger and the START signal via GPIO3. > > While at it, add description to the interrupts property. > > Signed-off-by: Jonathan Santos > --- ... > @@ -57,6 +80,15 @@ properties: > "#io-channel-cells": > const: 1 > > + "#trigger-source-cells": > + description: | > + Indicates the trigger source type for each entry: > + 0 = Synchronization GPIO-based trigger > + 1 = Synchronization device trigger (e.g., another ad7768-1) > + 2 = GPIO3 pin acting as START signal > + 3 = DRDY pin acting as SPI offload trigger > + const: 1 > + 0 and 1 don't sound like trigger outputs that this ADC is providing, so don't seem appropriate here. But the SYNC_OUT pin is missing from this list. Also, outputs could be used to trigger anything, not just SPI offload, so don't need to mention that.