From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AB15C4332F for ; Wed, 16 Nov 2022 09:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233059AbiKPJAs (ORCPT ); Wed, 16 Nov 2022 04:00:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233263AbiKPJAc (ORCPT ); Wed, 16 Nov 2022 04:00:32 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 111AB2180 for ; Wed, 16 Nov 2022 01:00:31 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id l12so28458042lfp.6 for ; Wed, 16 Nov 2022 01:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FVdV6LebjwCpmwDk6trJqC8cySRjktuHUoTqdWNdcms=; b=khTlLRnGvCZXS8zSbmdGUxyvWawM2fSnfv8ljuguxkvPyAT5UUql0SYa5oohRXhQTd I88GbIyvvk7Q5jqHMKbJtEm/uFyFy0ZmiUAnPm0/uFL+innZxOko6G7JEv2kZT/9hERJ th/tEufxqaMEx421Dyo6sxDbbABvx6rLxB997bMfwk+g/1DjUf9UXDUNk3t8XsM2WT4j pgG/vIRMFhV+6XQSwNYnzaAenrqk7fU49GBqbb0pPU13Q/4+JDNkIL0Y9u6ZoZmE8dQc Lm2pM5RzmBs8uGXIir8fPW7SJvcdkVYnEwLBs0Ajo6yXndizM7u2F1/Xes/K5ILVZPOB 9+4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FVdV6LebjwCpmwDk6trJqC8cySRjktuHUoTqdWNdcms=; b=pF32Ni/PKplneLNTp91zT6Ry1S4IxhP1dyna9i4Y0b41Hg+qCLNe2y98vcbvAWb5wt h5+reSx3Ba7Iq4TflzHXO8WNFPGJukGbbh1sBNVpsEYfkCuPy8VZ9K9T8ufQc8jcBXJM DaB/NhE8bCc1y0ZcjwNN/dXUfAYfGpd5qs9+58CDai+QNJ7L24tfzWo571WlOeqp4VJa PUhj0dcXyYNpR5KkD6CPqeSy4smoAj5L/Zl0DFm/xnk3zUhOFd9pDYOFb93FYion/iEd 6Go19G1pMKbd6zVNGIl/3ZrnJ606brbN9fpFMFQ0IVbek21C6HJFECtG/pS5JADWuF0c LjOg== X-Gm-Message-State: ANoB5pnTUXw+hvVWQxltHWKMUbBJY7gXt1LUuY5sGV2BmKIewxfKbzx3 6y0LC48wPXwl0oQVL3qvS4EZYw== X-Google-Smtp-Source: AA0mqf4ACaYKe07LviNcmJVRzmLlpSA+Y194j1OxaF80zT6bNeKpJkTnKfKaXj01iJCNB7gYnIy8Pg== X-Received: by 2002:a05:6512:239d:b0:4a2:7574:b64a with SMTP id c29-20020a056512239d00b004a27574b64amr6712826lfv.336.1668589229325; Wed, 16 Nov 2022 01:00:29 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id q21-20020a0565123a9500b0048afb8b8e53sm2510621lfu.80.2022.11.16.01.00.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 01:00:28 -0800 (PST) Message-ID: <3037b4f9-268d-df03-380c-393a5d01f3ba@linaro.org> Date: Wed, 16 Nov 2022 10:00:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 4/9] dt-bindings: Add RISC-V incoming MSI controller bindings Content-Language: en-US To: Conor Dooley , Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Atish Patra , Alistair Francis , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20221111044207.1478350-1-apatel@ventanamicro.com> <20221111044207.1478350-5-apatel@ventanamicro.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/11/2022 23:34, Conor Dooley wrote: > On Mon, Nov 14, 2022 at 05:59:00PM +0530, Anup Patel wrote: >> On Sun, Nov 13, 2022 at 8:18 PM Conor Dooley wrote: > >>> Also, the file name says "riscv,imsic", the description says "IMSIC" but >>> you've used "imsics" in the compatible. Is this a typo, or a plural? >> >> Yes, the file name should be consistent. I will update the file name. > > Is there a reason why the compatible is plural when all of the other > mentions etc do not have an "s"? It really did look like a typo to me. > > It's the "incoming MSI controller", so I am unsure as to where the "s" > actually even comes from. Why not just use "riscv,imsic"? Yep, should be rather consistent with all others, and IMSIC stands for Integrated Circuit? Best regards, Krzysztof