From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78ACDC433EF for ; Thu, 17 Feb 2022 21:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231995AbiBQVrW (ORCPT ); Thu, 17 Feb 2022 16:47:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234248AbiBQVrV (ORCPT ); Thu, 17 Feb 2022 16:47:21 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DCBC102439 for ; Thu, 17 Feb 2022 13:47:05 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id b20so1440835ljf.7 for ; Thu, 17 Feb 2022 13:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=J10hVBWBWzBnN+exLIwaL+UxouWVNqbJLTm7pqSm+BE=; b=ATtvKju4b79M/jlGSaaa271oSwLkRpHn1sF4RS9n30WWVnG/sKxH9v1KrfK+KGZ7tR F5qjZ782lKPEEcRN9TCSvnV2I/otD2d6CmlmlqIbIpvjwE+fxceX9yLizm5zXgHlXavV MwOqYvxdlnn+IEIdY4XdpxIG5ow9vgbN+ea+TjhdJ7UZwQz5YFdu/qCYlZaZeXQOxrJi gJVJEd7AY5GnV8/BTymP5P5nQkJ9l9nPi7Gxx6VXy3obBbXGUWON+45cIakbkWyXmDi/ zY3SpFuBu/A3wLcMh56TzRLtB2pmDgim79NoLO3z1TgZUFbxtivvDkZ0e45Nc1n+IZLb WDYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J10hVBWBWzBnN+exLIwaL+UxouWVNqbJLTm7pqSm+BE=; b=to95o7BzX72JFPf7w/fsaYAGP89aRChvs1+qjCuBjWokq+M9ZUNpqIXHBFapzcUJko 9yx7keuzg8liG17NahvEYna+zHgnMMy7fjVVNADO5weejyCuXvJMjqokxScLvXpwjOO+ 9uFl2K4KHPdRp+yfZvTybuDRWi/t7dN7nm1fi1rvFhQ8Z65KzP1N2LfglMSdgkaDkMkQ tEpYot1whfbIJge7x5AEK8vrH1sOheETAl4SgMVQaV9zlCmx4ZAdnNX97hp4FTlUC6vt FWx+M5WjMhu8KyPohgI9i7t2vpYSLJ9FPzVHvtkU0FULjlHqLwjYE5tkMLpbTFEapcjF moJw== X-Gm-Message-State: AOAM531AqklO5vZ0MhZqrfZENz0mCoBRs98CAWKHt4HVY0gSxKrKQ3XD YkwDAKBAFs062+4DLJWtSf6BC6No3ABkWuDl X-Google-Smtp-Source: ABdhPJxpDQiERpY2zy0r/iVc1+UZAfVfybaXvm5rYIPhgQAZ7dKty2RqqlvPEYAFxFbYqfBHKBbrIg== X-Received: by 2002:a05:651c:b8c:b0:246:c5c:84d7 with SMTP id bg12-20020a05651c0b8c00b002460c5c84d7mr3596579ljb.15.1645134423863; Thu, 17 Feb 2022 13:47:03 -0800 (PST) Received: from [192.168.1.102] (88-113-46-102.elisa-laajakaista.fi. [88.113.46.102]) by smtp.gmail.com with ESMTPSA id k12sm98678ljh.45.2022.02.17.13.47.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Feb 2022 13:47:03 -0800 (PST) Subject: Re: [PATCH 0/9] i2c: qcom-cci: fixes and updates To: Wolfram Sang , Loic Poulain , Robert Foss , Rob Herring , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20220203164629.1711958-1-vladimir.zapolskiy@linaro.org> From: Vladimir Zapolskiy Message-ID: <303a2bfd-b3d2-97a8-2438-fefe13a49962@linaro.org> Date: Thu, 17 Feb 2022 23:47:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Wolfram, On 2/17/22 9:57 PM, Wolfram Sang wrote: > >> Vladimir Zapolskiy (9): >> dt-bindings: i2c: qcom-cci: add QCOM SM8450 compatible >> dt-bindings: i2c: qcom-cci: add description of a vbus-supply property >> i2c: qcom-cci: don't delete an unregistered adapter >> i2c: qcom-cci: don't put a device tree node before i2c_add_adapter() >> i2c: qcom-cci: initialize CCI controller after registration of adapters >> i2c: qcom-cci: simplify probe by removing one loop over busses >> i2c: qcom-cci: simplify access to bus data structure >> i2c: qcom-cci: add support of optional vbus-supply regulators >> i2c: qcom-cci: add sm8450 compatible > > Patches 3+4 are already upstream. I wonder if patches 1+9 could be > applied to for-next also? Or is the vbus-supply a hard dependency here? > Patches 6+7 could probably also be resent individually after some > rebasing. > thank you for applying the fixes, 1/9 and 9/9 are also good to be applied for-next, there is no dependency on vbus-supply, so I would appreciate, if you take two more changes. As you suggested I'd start working on a generic support of such an optional bus supplier property, I believe at the moment everything is quite clear, I'll start from testing the previous solution, however my preference is to connect regulator on/off to master controller pm ops rather than slave pm ops. Additionally I am not quite satisfied with 'vbus-supply' name, some name without a confusing starting 'v' should be preferred IMO, like 'i2c-bus-supply' or 'sda-scl-supply', name suggestions are welcome. -- Best wishes, Vladimir