From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A9EC4332F for ; Thu, 3 Nov 2022 14:13:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbiKCON4 (ORCPT ); Thu, 3 Nov 2022 10:13:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231661AbiKCONg (ORCPT ); Thu, 3 Nov 2022 10:13:36 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23927DF83; Thu, 3 Nov 2022 07:13:34 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 63F156600371; Thu, 3 Nov 2022 14:13:32 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667484813; bh=YMDhUlxAMoErZnevFRjtflBeFHbeFJyuQG5fGsxeGjU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=carv6v1UqdiDgoqsuWL22pY1kUvuJsxrgk8qTDZ+C6kuQ1qfAPxBPVIPxF+iqhkue UJ9jOaHf4rK5kG6e5wGwak13uscIVpVNvxwi/KN7BEOc1qieEVM50xtZeDskrnWu/i OvCT91g3/MWGeXArj24tr+8vV5Vpezs0Y0aRm3x4uF65ZrlsYzXWBK5wC44+5yNOrK DNeIgAdrhA9BLwavhxNWIBrbsg4lUVfr7jfWKIRVrXS2/qlAdp7eT8Zyf+Hi69kEZQ DxpRHbTNsjigCFi9SvkZZJ0OlVtrkcu/l9utQleQ+gsNGMnFAVL5bCw0iXul0Wkahk /LHChCd6BcPrQ== Message-ID: <3046551a-62d7-2990-afb6-75fe2e20d8cb@collabora.com> Date: Thu, 3 Nov 2022 15:13:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v3 net-next 1/8] arm64: dts: mediatek: mt7986: add support for RX Wireless Ethernet Dispatch Content-Language: en-US To: Lorenzo Bianconi , netdev@vger.kernel.org Cc: nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, lorenzo.bianconi@redhat.com, Bo.Jiao@mediatek.com, sujuan.chen@mediatek.com, ryder.Lee@mediatek.com, evelyn.tsai@mediatek.com, devicetree@vger.kernel.org, robh+dt@kernel.org, daniel@makrotopia.org, krzysztof.kozlowski+dt@linaro.org References: <4bd5f6626174ac042c0e9b9f2ffff40c3c72b88a.1667466887.git.lorenzo@kernel.org> From: AngeloGioacchino Del Regno In-Reply-To: <4bd5f6626174ac042c0e9b9f2ffff40c3c72b88a.1667466887.git.lorenzo@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 03/11/22 10:28, Lorenzo Bianconi ha scritto: > Similar to TX Wireless Ethernet Dispatch, introduce RX Wireless Ethernet > Dispatch to offload traffic received by the wlan interface to lan/wan > one. > > Co-developed-by: Sujuan Chen > Signed-off-by: Sujuan Chen > Signed-off-by: Lorenzo Bianconi Hello Lorenzo, thanks for the patch! However, there's something to improve... > --- > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 75 +++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > index 72e0d9722e07..b0a593c6020e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi ..snip.. > @@ -226,6 +252,12 @@ ethsys: syscon@15000000 { > reg = <0 0x15000000 0 0x1000>; > #clock-cells = <1>; > #reset-cells = <1>; > + > + ethsysrst: reset-controller { That's not right. It works, yes, but your ethsys rightfully declares #reset-cells, because it is supposed to also be a reset controller (even though I don't see any reset controller registering action in clk-mt7986-eth.c). Please document the ethernet reset in the appropriate dt-bindings header and register the reset controller in clk-mt7986-eth.c. Finally, you won't need any "ti,syscon-reset" node, and resets will look like resets = <ðsys MT7986_ETHSYS_SOMETHING_SWRST>; If you need any hint about how to do that, please check clk-mt8195-infra_ao.c. Regards, Angelo