Re: [PATCH v5 0/6] ARM: dts: add support for exynos hdmi subsystem

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi Rahul,

On Monday 26 of August 2013 15:08:15 Rahul Sharma wrote:
> It adds Device tree nodes and clocks information for HDMI subsystem
> for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi
> hpd gpio and update binding documents.
> 
> This set is based on kukjin's for-next branch at
> http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git.
> 
> v5:
> 1) Merged Clock addition patch to DT nmde addition patch.
> 2) Add dout_pixel clock for hdmi in place of sclk_pixel.
> 3) Enable mixer node in soc dtsi file.
> 
> v4:
> 1) Remove the movement of common properties to Exynos5.dtsi for
> I2C and hdmi subsystem.
> 2) Change the title of the patches.
> 
> v3:
> 1) Rebase to kgene for-next based on 3.11-rc1.
> 2) Changes clock numbers as per updated clocks file for
> exyno5250 and exynos5420.
> 3) Dropped Sachin patch as already got merged.
> 
> v2:
> 1) Added patch for moving common i2c properties to exynos5.dtsi
> 2) Added patch for moving common hdmi, mixer properties to exynos5.dtsi
> 3) moved hpd pinctrl node to board file.
> 4) Added Sachin's patch to update binding document for hdmi with hpd
> information.
> 
> 
> 
> Andrew Bresticker (1):
>   ARM: dts: add i2c device nodes for Exynos5420
> 
> Rahul Sharma (4):
>   ARM: dts: add clocks to hdmi dt node for exynos5250
>   ARM: dts: add dt nodes for hdmi subsystem for exynos5420
>   ARM: dts: add hdmi hpd gpio pinctrl node for exynos5420
>   of/documentation: update with clock information for exynos hdmi
>     subsystem
> 
> Sean Paul (1):
>   ARM: dts: add mixer clocks to mixer node for Exynos5250
> 
>  .../devicetree/bindings/video/exynos_hdmi.txt      |   14 +++-
>  .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
>  arch/arm/boot/dts/exynos5250.dtsi                  |    8 ++-
>  arch/arm/boot/dts/exynos5420-smdk5420.dts          |   26 +++++++
>  arch/arm/boot/dts/exynos5420.dtsi                  |   75
> ++++++++++++++++++++ 5 files changed, 123 insertions(+), 4 deletions(-)

Except patches 4-6, which I have commented on, for the series:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Also one minor comment: It would be better if you updated the 
documentation as first patch. This would make all the following patches to 
be based on already existing documentation.

Best regards,
Tomasz