From: Marek Vasut <marek.vasut@mailbox.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: dri-devel@lists.freedesktop.org,
Conor Dooley <conor+dt@kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
David Airlie <airlied@gmail.com>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>, Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/panel: ilitek-ili9881c: Add configuration for 5" Raspberry Pi 720x1280
Date: Thu, 4 Sep 2025 22:58:52 +0200 [thread overview]
Message-ID: <30974d20-951a-456e-9040-ca9b0ee2c338@mailbox.org> (raw)
In-Reply-To: <33t4oznhr442t6xu2xccjanc5ujdbzo7m3gtmqe6aqpzevazgk@5fachuynkvsu>
On 9/4/25 10:21 PM, Dmitry Baryshkov wrote:
[...]
>> + ILI9881C_COMMAND_INSTR(0xD1, 0x52),
>> + ILI9881C_COMMAND_INSTR(0xD2, 0x63),
>> + ILI9881C_COMMAND_INSTR(0xD3, 0x39),
>> +};
>
> Should the hex be lower-cased? Other than that LGTM.
Fixed in V2, thanks.
The other panel entries are fixed in
[PATCH] drm/panel: ilitek-ili9881c: Turn ILI9881C_COMMAND_INSTR()
parameters lowercase
next prev parent reply other threads:[~2025-09-04 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 20:01 [PATCH 1/2] dt-bindings: ili9881c: Document 5" Raspberry Pi 720x1280 Marek Vasut
2025-09-04 20:01 ` [PATCH 2/2] drm/panel: ilitek-ili9881c: Add configuration for " Marek Vasut
2025-09-04 20:21 ` Dmitry Baryshkov
2025-09-04 20:58 ` Marek Vasut [this message]
2025-09-05 18:40 ` [PATCH 1/2] dt-bindings: ili9881c: Document " Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30974d20-951a-456e-9040-ca9b0ee2c338@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).