From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>,
devicetree@vger.kernel.org
Cc: Stephan Gerhold <stephan@gerhold.net>,
Nikita Travkin <nikita@trvn.ru>,
Julian Ribbeck <julian.ribbeck@gmx.de>,
Josef W Menad <JosefWMenad@protonmail.ch>,
Markuss Broks <markuss.broks@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree
Date: Wed, 28 Sep 2022 19:14:54 +0200 [thread overview]
Message-ID: <309ff92e-16ef-09c0-5ed6-fb2e13f2d62b@linaro.org> (raw)
In-Reply-To: <20220928165920.181087-1-linmengbo0689@protonmail.com>
On 28/09/2022 19:00, Lin, Meng-Bo wrote:
> The smartphones below are using the MSM8916 SoC,
> which are released in 2015-2016:
>
> Samsung Galaxy J5 2015 (SM-J500*)
> Samsung Galaxy J5 2016 (SM-J510*)
> Samsung Galaxy J3 2016
> - SM-J3109/SM-J320Y/SM-J320YZ
> - SM-J320N0/SM-J320ZN
> - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL
>
> Add a common device tree for with initial support for:
>
> - GPIO keys
> - SDHCI (internal and external storage)
> - USB Device Mode
> - UART (on USB connector via the SM5703 MUIC)
> - WCNSS (WiFi/BT)
> - Regulators
>
> The three devices (some varints of J3, all other variants of J5 released
> in 2015 and J5X released in 2016) are very similar, with some differences
> in display and GPIO pins. The common parts are shared in
> msm8916-samsung-j5-common.dtsi to reduce duplication.
>
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
> ---
> ...6-samsung-j5.dts => msm8916-samsung-j5-common.dtsi} | 10 ++--------
Nope, we loose a board in this commit. Your changes are still not
bisectable - board is gone.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-28 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 16:50 [RESEND PATCH v3 0/5] arm64: dts: qcom: msm8916-samsung-j5: Use common device tree Lin, Meng-Bo
2022-09-28 16:54 ` [PATCH v3 1/5] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo
2022-09-28 17:00 ` [PATCH v3 2/5] arm64: dts: qcom: msm8916-samsung-j5: Drop from Makefile Lin, Meng-Bo
2022-09-28 17:14 ` Krzysztof Kozlowski
2022-09-28 17:00 ` [PATCH v3 3/5] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree Lin, Meng-Bo
2022-09-28 17:14 ` Krzysztof Kozlowski [this message]
2022-09-28 17:00 ` [PATCH v3 4/5] arm64: dts: qcom: msm8916-samsung-j5: Use " Lin, Meng-Bo
2022-09-28 17:00 ` [PATCH v3 5/5] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor Lin, Meng-Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309ff92e-16ef-09c0-5ed6-fb2e13f2d62b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=JosefWMenad@protonmail.ch \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=julian.ribbeck@gmx.de \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linmengbo0689@protonmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).