From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63DB0C46467 for ; Tue, 29 Nov 2022 01:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234773AbiK2Brb (ORCPT ); Mon, 28 Nov 2022 20:47:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234872AbiK2Br3 (ORCPT ); Mon, 28 Nov 2022 20:47:29 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D035E42F57; Mon, 28 Nov 2022 17:47:23 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 5E74624DE6E; Tue, 29 Nov 2022 09:47:20 +0800 (CST) Received: from EXMBX065.cuchost.com (172.16.6.65) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 29 Nov 2022 09:47:20 +0800 Received: from [192.168.125.66] (113.72.147.18) by EXMBX065.cuchost.com (172.16.6.65) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 29 Nov 2022 09:47:19 +0800 Message-ID: <30c21787-0c48-ff50-1d63-8e69bdcdbe30@starfivetech.com> Date: Tue, 29 Nov 2022 09:47:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/5] dt-bindings: pinctrl: Add StarFive JH7110 pinctrl definitions Content-Language: en-US To: Krzysztof Kozlowski , Hal Feng , , , CC: Conor Dooley , Palmer Dabbelt , "Rob Herring" , Krzysztof Kozlowski , Linus Walleij , Emil Renner Berthing , References: <20221118011108.70715-1-hal.feng@starfivetech.com> <20221118011108.70715-2-hal.feng@starfivetech.com> <08db0f3b-5222-9460-26ba-0e6380d16583@linaro.org> <0ceba170-f844-e733-a49e-e67746f9f836@starfivetech.com> <093ea507-4c42-1af9-4896-64c1a918432e@linaro.org> From: Jianlong Huang In-Reply-To: <093ea507-4c42-1af9-4896-64c1a918432e@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.147.18] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX065.cuchost.com (172.16.6.65) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 28 Nov 2022 09:32:45 +0100, Krzysztof Kozlowski wrote: > On 28/11/2022 01:48, Jianlong Huang wrote: > >>>>> +/* aon_iomux doen */ >>>>> +#define GPOEN_AON_PTC0_OE_N_4 2 >>>>> +#define GPOEN_AON_PTC0_OE_N_5 3 >>>>> +#define GPOEN_AON_PTC0_OE_N_6 4 >>>>> +#define GPOEN_AON_PTC0_OE_N_7 5 >>>>> + >>>> >>>> It looks like you add register constants to the bindings. Why? The >>>> bindings are not the place to represent hardware programming model. Not >>>> mentioning that there is no benefit in this. >>> >>> Also: this entire file should be dropped, but if it stays, you have to >>> name it matching bindings or compatible (vendor,device.h). >> >> Thanks your comments. >> These macros are used to configure pinctrl in dts, so the file should stay, > > Why they should stay? What's the reason? If it is not a constant used by > driver, then register values should not be placed in the bindings, so > drop it. > Thanks. These macros in binding header(example, DOUT, DOEN etc) will be used in DTS, and driver will parse the DT for pinctrl configuration. Example in dts: uart0_pins: uart0-0 { tx-pins { pinmux = ; bias-disable; drive-strength = <12>; input-disable; input-schmitt-disable; slew-rate = <0>; }; rx-pins { pinmux = ; bias-pull-up; drive-strength = <2>; input-enable; input-schmitt-enable; slew-rate = <0>; }; }; Best regards, Jianlong Huang