devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <robh@kernel.org>
Cc: <broonie@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<agross@kernel.org>, <bjorn.andersson@linaro.org>,
	<krzysztof.kozlowski@linaro.org>, <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples
Date: Thu, 26 May 2022 14:08:06 +0000	[thread overview]
Message-ID: <30c474d2-835c-0802-5af5-380b8374f38f@microchip.com> (raw)
In-Reply-To: <20220526140141.GB3831942-robh@kernel.org>

On 26/05/2022 15:01, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, May 26, 2022 at 06:52:23AM +0000, Conor.Dooley@microchip.com wrote:
>> On 26/05/2022 02:41, Rob Herring wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> The 'unevaluatedProperties' schema checks is not fully working and doesn't
>>> catch some cases where there's a $ref to another schema. A fix is pending,
>>> but results in new warnings in examples.
>>>
>>> 'spi-max-frequency' is supposed to be a per SPI peripheral device property,
>>> not a SPI controller property, so drop it.
>>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>
>> As this property is in the mpfs devicetree & I'll need to fix it, is this
>> patch targeted at 5.19? (I assume given the window is open and there's no
>> fixes tag that it isn't).
> 
> 5.18 ideally because warnings are going to appear when I push the

18? That a typo or am I missing something? Either way, will send the dt
fix shortly.
Thanks,
Conor.

> dtschema fix for 'unevaluatedProperties'.
> 
> Rob


  reply	other threads:[~2022-05-26 14:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  1:41 [PATCH] spi: dt-bindings: Fix unevaluatedProperties warnings in examples Rob Herring
2022-05-26  6:49 ` Krzysztof Kozlowski
2022-05-26  6:52 ` Conor.Dooley
2022-05-26 14:01   ` Rob Herring
2022-05-26 14:08     ` Conor.Dooley [this message]
2022-06-06 16:13 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30c474d2-835c-0802-5af5-380b8374f38f@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).