devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wilson Ding <dingwei@marvell.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: andrew@lunn.ch, gregory.clement@bootlin.com,
	sebastian.hesselbarth@gmail.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de,
	salee@marvell.com, gakula@marvell.com
Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Add Armada8K reset controller
Date: Fri, 28 Feb 2025 07:55:38 +0100	[thread overview]
Message-ID: <30c4f57d-0385-4f33-a911-b18e926dd3d6@kernel.org> (raw)
In-Reply-To: <20250227192536.2426490-2-dingwei@marvell.com>

On 27/02/2025 20:25, Wilson Ding wrote:

> +    maxItems: 1
> +
> +  "#reset-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#reset-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    syscon0: system-controller@440000 {
> +        compatible = "syscon", "simple-mfd";

Drop entire node. Neither correct, nor needed.

> +        reg = <0x440000 0x2000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        swrst: reset-controller@268 {
> +            compatible = "marvell,armada8k-reset";
> +            reg = <0x268 0x4>;
> +            #reset-cells = <1>;
> +        };



Best regards,
Krzysztof

  parent reply	other threads:[~2025-02-28  6:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 19:25 [PATCH v3 0/3] Add Armada8K reset controller support Wilson Ding
2025-02-27 19:25 ` [PATCH v3 1/3] dt-bindings: reset: Add Armada8K reset controller Wilson Ding
2025-02-27 20:24   ` Rob Herring (Arm)
2025-02-27 21:58     ` [EXTERNAL] " Wilson Ding
2025-02-28  6:52       ` Krzysztof Kozlowski
2025-03-07  0:03         ` Wilson Ding
2025-03-07  8:56           ` Krzysztof Kozlowski
2025-03-07 23:15             ` Wilson Ding
2025-02-28  6:55   ` Krzysztof Kozlowski [this message]
2025-02-27 19:25 ` [PATCH v3 2/3] reset: Add support for " Wilson Ding
2025-02-27 19:25 ` [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller node Wilson Ding
2025-02-28  6:56   ` Krzysztof Kozlowski
2025-02-28 20:18     ` [EXTERNAL] " Wilson Ding
2025-03-01 13:46       ` Krzysztof Kozlowski
2025-03-01 13:49         ` Krzysztof Kozlowski
2025-03-04  2:17         ` Wilson Ding
2025-03-04  7:13           ` Krzysztof Kozlowski
2025-03-04 19:08             ` Wilson Ding
2025-03-06  7:29               ` Krzysztof Kozlowski
2025-03-06 17:42                 ` [EXTERNAL] " Wilson Ding
2025-03-07  8:59                   ` Krzysztof Kozlowski
2025-03-07 21:52                     ` Wilson Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30c4f57d-0385-4f33-a911-b18e926dd3d6@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dingwei@marvell.com \
    --cc=gakula@marvell.com \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=salee@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).