From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: allen.chen@ite.com.tw
Cc: treapking@chromium.org, Jau-Chih.Tseng@ite.com.tw,
Hermes.Wu@ite.com.tw, Kenneth.Hung@ite.com.tw,
andrzej.hajda@intel.com, narmstrong@baylibre.com,
robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
Date: Wed, 2 Nov 2022 12:33:58 -0400 [thread overview]
Message-ID: <30ce6ed4-cbea-7b82-cca5-8920fc1eddad@linaro.org> (raw)
In-Reply-To: <18659f5a5b2c4fd7b76731836aeb713d@ite.com.tw>
On 02/11/2022 02:54, allen.chen@ite.com.tw wrote:
> On 26/10/2022 23:01, allen wrote:
>> From: allen chen <allen.chen@ite.com.tw>
>>
>> Add properties to restrict dp output data-lanes and clock.
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all requested changes or keep discussing them.
>
> Thank you.
>
> ==> I am sorry I didn't find the missing advice you said. Could you explain it again?
>
> Rob asked - Commit msg should explain reason for breaking users.
And where is the reason? I saw only one sentence "Add properties to
restrict dp output data-lanes and clock."
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-02 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 3:01 [PATCH v6 0/2] *** IT6505 driver read dt properties *** allen
2022-10-27 3:01 ` [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen
2022-10-28 1:58 ` Krzysztof Kozlowski
2022-11-02 6:54 ` allen.chen
2022-11-02 16:33 ` Krzysztof Kozlowski [this message]
2022-11-03 8:27 ` allen.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30ce6ed4-cbea-7b82-cca5-8920fc1eddad@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Hermes.Wu@ite.com.tw \
--cc=Jau-Chih.Tseng@ite.com.tw \
--cc=Kenneth.Hung@ite.com.tw \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=allen.chen@ite.com.tw \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=treapking@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).