* [PATCH] media: dt-bindings: drop unneeded status from examples
@ 2023-07-25 10:16 Krzysztof Kozlowski
2023-07-25 10:55 ` Benjamin Mugnier
2023-07-25 18:40 ` Conor Dooley
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-25 10:16 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Benjamin Mugnier, Sylvain Petinot, linux-tegra,
linux-media, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Example DTS should not have 'status' property.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml | 1 -
Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml | 1 -
2 files changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
index 369c48fd9bf9..a6b73498bc21 100644
--- a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
+++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
@@ -53,6 +53,5 @@ examples:
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&tegra_car TEGRA124_CLK_CEC>;
clock-names = "cec";
- status = "disabled";
hdmi-phandle = <&hdmi>;
};
diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
index 19a39d753aad..b68141264c0e 100644
--- a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
@@ -143,7 +143,6 @@ examples:
mipid02: csi2rx@14 {
compatible = "st,st-mipid02";
reg = <0x14>;
- status = "okay";
clocks = <&clk_ext_camera_12>;
clock-names = "xclk";
VDDE-supply = <&vdd>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] media: dt-bindings: drop unneeded status from examples
2023-07-25 10:16 [PATCH] media: dt-bindings: drop unneeded status from examples Krzysztof Kozlowski
@ 2023-07-25 10:55 ` Benjamin Mugnier
2023-07-26 6:33 ` Krzysztof Kozlowski
2023-07-25 18:40 ` Conor Dooley
1 sibling, 1 reply; 5+ messages in thread
From: Benjamin Mugnier @ 2023-07-25 10:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Hans Verkuil, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Sylvain Petinot, linux-tegra, linux-media,
devicetree, linux-kernel
Hi Krzysztof,
Thank you for your patch.
For the st-mipid02 :
Reviewed-By: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
On 7/25/23 12:16, Krzysztof Kozlowski wrote:
> Example DTS should not have 'status' property.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml | 1 -
> Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
> index 369c48fd9bf9..a6b73498bc21 100644
> --- a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
> +++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
> @@ -53,6 +53,5 @@ examples:
> interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&tegra_car TEGRA124_CLK_CEC>;
> clock-names = "cec";
> - status = "disabled";
> hdmi-phandle = <&hdmi>;
> };
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
> index 19a39d753aad..b68141264c0e 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-mipid02.yaml
> @@ -143,7 +143,6 @@ examples:
> mipid02: csi2rx@14 {
> compatible = "st,st-mipid02";
> reg = <0x14>;
> - status = "okay";
> clocks = <&clk_ext_camera_12>;
> clock-names = "xclk";
> VDDE-supply = <&vdd>;
--
Regards,
Benjamin
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: dt-bindings: drop unneeded status from examples
2023-07-25 10:55 ` Benjamin Mugnier
@ 2023-07-26 6:33 ` Krzysztof Kozlowski
2023-07-31 9:30 ` Benjamin Mugnier
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-26 6:33 UTC (permalink / raw)
To: Benjamin Mugnier, Hans Verkuil, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Sylvain Petinot, linux-tegra, linux-media,
devicetree, linux-kernel
On 25/07/2023 12:55, Benjamin Mugnier wrote:
> Hi Krzysztof,
>
> Thank you for your patch.
>
> For the st-mipid02 :
> Reviewed-By: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
I don't think we have half-reviews. There are half-acks, but not reviews.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L542
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: dt-bindings: drop unneeded status from examples
2023-07-26 6:33 ` Krzysztof Kozlowski
@ 2023-07-31 9:30 ` Benjamin Mugnier
0 siblings, 0 replies; 5+ messages in thread
From: Benjamin Mugnier @ 2023-07-31 9:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Hans Verkuil, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Sylvain Petinot, linux-tegra, linux-media,
devicetree, linux-kernel
On 7/26/23 08:33, Krzysztof Kozlowski wrote:
> On 25/07/2023 12:55, Benjamin Mugnier wrote:
>> Hi Krzysztof,
>>
>> Thank you for your patch.
>>
>> For the st-mipid02 :
>> Reviewed-By: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>
> I don't think we have half-reviews. There are half-acks, but not reviews.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L542
>
> Best regards,
> Krzysztof
>
I was not aware of this, thanks for pointing it to me.
For the st-mipid02 :
Acked-By: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
--
Regards,
Benjamin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: dt-bindings: drop unneeded status from examples
2023-07-25 10:16 [PATCH] media: dt-bindings: drop unneeded status from examples Krzysztof Kozlowski
2023-07-25 10:55 ` Benjamin Mugnier
@ 2023-07-25 18:40 ` Conor Dooley
1 sibling, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2023-07-25 18:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Benjamin Mugnier, Sylvain Petinot, linux-tegra,
linux-media, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
On Tue, Jul 25, 2023 at 12:16:25PM +0200, Krzysztof Kozlowski wrote:
> Example DTS should not have 'status' property.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-31 9:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 10:16 [PATCH] media: dt-bindings: drop unneeded status from examples Krzysztof Kozlowski
2023-07-25 10:55 ` Benjamin Mugnier
2023-07-26 6:33 ` Krzysztof Kozlowski
2023-07-31 9:30 ` Benjamin Mugnier
2023-07-25 18:40 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).