From: <Sergiu.Moga@microchip.com>
To: <ilpo.jarvinen@linux.intel.com>
Cc: <lee@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Claudiu.Beznea@microchip.com>, <richard.genoud@gmail.com>,
<radu_nicolae.pirea@upb.ro>, <gregkh@linuxfoundation.org>,
<broonie@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <jirislaby@kernel.org>, <admin@hifiphile.com>,
<Kavyasree.Kotagiri@microchip.com>, <Tudor.Ambarus@microchip.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 08/13] tty: serial: atmel: Define GCLK as USART baudrate source clock
Date: Wed, 7 Sep 2022 09:37:38 +0000 [thread overview]
Message-ID: <30d9a39c-0630-89e6-43da-47a8be4d1277@microchip.com> (raw)
In-Reply-To: <5d3e3a73-8b13-fb23-a32c-565046ec3c27@linux.intel.com>
On 07.09.2022 12:21, Ilpo Järvinen wrote:
> On Tue, 6 Sep 2022, Sergiu Moga wrote:
>
>> Define the bit that represents the choice of having GCLK as a baudrate
>> source clock inside the USCLKS bitmask of the Mode Register of
>> USART IP's.
>>
>> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
>> ---
>>
>>
>> v1 -> v2:
>> - Nothing, this patch was not here before
>>
>>
>>
>> drivers/tty/serial/atmel_serial.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/serial/atmel_serial.h b/drivers/tty/serial/atmel_serial.h
>> index 0d8a0f9cc5c3..70d0611e56fd 100644
>> --- a/drivers/tty/serial/atmel_serial.h
>> +++ b/drivers/tty/serial/atmel_serial.h
>> @@ -49,6 +49,7 @@
>> #define ATMEL_US_USCLKS GENMASK(5, 4) /* Clock Selection */
>> #define ATMEL_US_USCLKS_MCK (0 << 4)
>> #define ATMEL_US_USCLKS_MCK_DIV8 (1 << 4)
>> +#define ATMEL_US_USCLKS_GCLK (2 << 4)
>
> This would be FIELD_PREP(ATMEL_US_USCLKS, 2) from linux/bitfield.h.
>
> They should all be converted to use FIELD_PREP(), IMHO (in a separate
> patch).
>
>> #define ATMEL_US_USCLKS_SCK (3 << 4)
>> #define ATMEL_US_CHRL GENMASK(7, 6) /* Character Length */
>> #define ATMEL_US_CHRL_5 (0 << 6)
>>
>
> --
> i.
>
Yes, I guess that is a good idea. After these additional
macro-definitions are upstreamed, I will try to send some patches for
the conversion.
Thanks,
Sergiu
next prev parent reply other threads:[~2022-09-07 9:37 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 13:54 [PATCH v2 00/13] Make atmel serial driver aware of GCLK Sergiu Moga
2022-09-06 13:55 ` [PATCH v2 01/13] spi: dt-bindings: atmel,at91rm9200-spi: Add DMA related properties Sergiu Moga
2022-09-06 15:12 ` Mark Brown
2022-09-06 21:41 ` Rob Herring
2022-09-07 7:54 ` Sergiu.Moga
2022-09-08 12:23 ` Krzysztof Kozlowski
2022-09-06 13:55 ` [PATCH v2 02/13] ARM: dts: at91: sama7g5: Swap rx and tx for spi11 Sergiu Moga
2022-09-06 13:55 ` [PATCH v2 03/13] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding Sergiu Moga
2022-09-08 12:23 ` Krzysztof Kozlowski
2022-09-06 13:55 ` [PATCH v2 04/13] ARM: dts: at91: sam9x60ek: Add DBGU compatibles to uart1 Sergiu Moga
2022-09-06 13:55 ` [PATCH v2 05/13] dt-bindings: serial: atmel,at91-usart: convert to json-schema Sergiu Moga
2022-09-08 12:29 ` Krzysztof Kozlowski
2022-09-08 15:06 ` Sergiu.Moga
2022-09-08 15:10 ` Krzysztof Kozlowski
2022-09-08 15:27 ` Sergiu.Moga
2022-09-08 16:05 ` Krzysztof Kozlowski
2022-09-06 13:55 ` [PATCH v2 06/13] dt-bindings: serial: atmel,at91-usart: Add SAM9260 compatibles to SAM9x60 Sergiu Moga
2022-09-08 12:30 ` Krzysztof Kozlowski
2022-09-08 15:15 ` Sergiu.Moga
2022-09-09 1:36 ` Rob Herring
2022-09-12 7:45 ` Sergiu.Moga
2022-09-12 10:44 ` Krzysztof Kozlowski
2022-09-12 13:09 ` Sergiu.Moga
2022-09-13 8:58 ` Krzysztof Kozlowski
2022-09-13 9:19 ` Sergiu.Moga
2022-09-13 9:30 ` Krzysztof Kozlowski
2022-09-13 9:35 ` Sergiu.Moga
2022-09-06 13:55 ` [PATCH v2 07/13] dt-bindings: mfd: atmel,sama5d2-flexcom: Add USART child node ref binding Sergiu Moga
2022-09-08 12:33 ` Krzysztof Kozlowski
2022-09-06 13:55 ` [PATCH v2 08/13] tty: serial: atmel: Define GCLK as USART baudrate source clock Sergiu Moga
2022-09-07 9:21 ` Ilpo Järvinen
2022-09-07 9:37 ` Sergiu.Moga [this message]
2022-09-06 13:55 ` [PATCH v2 09/13] tty: serial: atmel: Define BRSRCCK bitmask of UART IP's Mode Register Sergiu Moga
2022-09-07 9:24 ` Ilpo Järvinen
2022-09-06 13:55 ` [PATCH v2 10/13] tty: serial: atmel: Only divide Clock Divisor if the IP is USART Sergiu Moga
2022-09-07 9:23 ` Ilpo Järvinen
2022-09-07 9:34 ` Sergiu.Moga
2022-09-06 13:55 ` [PATCH v2 11/13] clk: at91: sama5d2: Add Generic Clocks for UART/USART Sergiu Moga
2022-09-06 13:55 ` [PATCH v2 12/13] tty: serial: atmel: Make the driver aware of the existence of GCLK Sergiu Moga
2022-09-07 9:36 ` Ilpo Järvinen
2022-09-07 11:11 ` Sergiu.Moga
2022-09-07 11:29 ` Ilpo Järvinen
2022-09-12 8:06 ` Claudiu.Beznea
2022-09-06 13:55 ` [PATCH v2 13/13] dt-bindings: serial: atmel,at91-usart: Add gclk as a possible USART clock Sergiu Moga
2022-09-08 12:35 ` Krzysztof Kozlowski
2022-09-08 15:33 ` Sergiu.Moga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30d9a39c-0630-89e6-43da-47a8be4d1277@microchip.com \
--to=sergiu.moga@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=admin@hifiphile.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).