From: Jon Hunter <jonathanh@nvidia.com>
To: Sameer Pujar <spujar@nvidia.com>,
thierry.reding@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: mkumard@nvidia.com, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: tegra: enable ACONNECT, ADMA and AGIC
Date: Wed, 12 Jun 2019 14:01:18 +0100 [thread overview]
Message-ID: <30df3490-a263-233f-3775-b719d76e3302@nvidia.com> (raw)
In-Reply-To: <ce8e26f7-4ed0-a5a4-821b-fdfa3a7e334e@nvidia.com>
On 12/06/2019 13:44, Sameer Pujar wrote:
>
> On 6/12/2019 6:07 PM, Jon Hunter wrote:
>>
>> On 11/06/2019 09:56, Sameer Pujar wrote:
>>> Enable ACONNECT, ADMA and AGIC devices for following platforms
>>> * Jetson TX2
>>> * Jetson Xavier
>>>
>>> Verified driver probe path and devices get registered fine.
>>>
>>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>>> ---
>>> arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 12 ++++++++++++
>>> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 12 ++++++++++++
>>> 2 files changed, 24 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
>>> b/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
>>> index 5102de1..b818355 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
>>> @@ -298,4 +298,16 @@
>>> vin-supply = <&vdd_5v0_sys>;
>>> };
>>> };
>>> +
>>> + aconnect@2a41000 {
>>> + status = "okay";
>>> +
>>> + dma-controller@2930000 {
>>> + status = "okay";
>>> + };
>>> +
>>> + agic@2a41000 {
>>> + status = "okay";
>>> + };
>>> + };
>>> };
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
>>> b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
>>> index 6e6df65..d1cc028 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
>>> @@ -167,4 +167,16 @@
>>> };
>>> };
>>> };
>>> +
>>> + aconnect@2a41000 {
>>> + status = "okay";
>>> +
>>> + dma-controller@2930000 {
>>> + status = "okay";
>>> + };
>>> +
>>> + agic@2a41000 {
>>> + status = "okay";
>>> + };
>>> + };
>>> };
>>>
>> I believe that I have already ACK'ed this, so please include for the
>> next revision.
> There is a small change related to dma node.
> Will include ACK in the next revision.
OK. I had assumed there was no change. Ah the 'dma-controller' name!
Usually you should list the changes for each revision under the '---'
beneath the signed-off line so people can see if there are any changes.
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2019-06-12 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 8:56 [PATCH v2 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes Sameer Pujar
2019-06-11 8:56 ` [PATCH v2 2/2] arm64: tegra: enable ACONNECT, ADMA and AGIC Sameer Pujar
2019-06-12 12:37 ` Jon Hunter
2019-06-12 12:44 ` Sameer Pujar
2019-06-12 13:01 ` Jon Hunter [this message]
2019-06-12 12:36 ` [PATCH v2 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes Jon Hunter
2019-06-12 12:59 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30df3490-a263-233f-3775-b719d76e3302@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkumard@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox