From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Jack Pham <jackp@codeaurora.org>, Rob Herring <robh@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
gregkh@linuxfoundation.org, mark.rutland@arm.com, kishon@ti.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, shawn.guo@linaro.org,
vkoul@kernel.org, Manu Gautam <mgautam@codeaurora.org>,
Sriharsha Allenki <sallenki@codeaurora.org>
Subject: Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings
Date: Fri, 21 Dec 2018 08:40:29 +0100 [thread overview]
Message-ID: <3107e7b1-7d5f-8a67-34ec-e2d6f31cb28f@linaro.org> (raw)
In-Reply-To: <20181220173633.GA19912@jackp-linux.qualcomm.com>
On 12/20/18 18:37, Jack Pham wrote:
> Hi Rob, Jorge,
>
> On Thu, Dec 20, 2018 at 11:05:31AM -0600, Rob Herring wrote:
>> On Fri, Dec 07, 2018 at 10:55:57AM +0100, Jorge Ramirez-Ortiz wrote:
>>> Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY
>>> controller embedded in QCS404.
>>>
>>> Based on Sriharsha Allenki's <sallenki@codeaurora.org> original
>>> definitions.
>>>
>>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>>> Reviewed-by: Vinod Koul <vkoul@kernel.org>
>>> ---
>>> .../devicetree/bindings/usb/qcom,usb-ssphy.txt | 78 ++++++++++++++++++++++
>>> 1 file changed, 78 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
>>> new file mode 100644
>>> index 0000000..fcf4e01
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
>>> @@ -0,0 +1,78 @@
>>> +Qualcomm Synopsys 1.0.0 SS phy controller
>>> +===========================================
>>> +
>>> +Synopsys 1.0.0 ss phy controller supports SS usb connectivity on Qualcomm
>>> +chipsets
>>> +
>>> +Required properties:
>>> +
>>> +- compatible:
>>> + Value type: <string>
>>> + Definition: Should contain "qcom,usb-ssphy".
>> What is "qcom,dwc3-ss-usb-phy" which already exists then?
> Uh, apparently only the bindings doc is there but the driver never
> landed. I guess it fell through the cracks nearly 4 years ago.
>
> https://lore.kernel.org/patchwork/patch/499502/
>
> Jorge, does Andy's version of this driver at all resemble what can be
> used for QCS404?
the drivers seem quite different but I'll give it a go as well and
compare (it is my understanding that the controller is the same - I will
have access to the hardware documentation soon to compare)
but I'll come back to you on this.
>
> Jack
next prev parent reply other threads:[~2018-12-21 7:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 9:55 [PATCH 0/2] USB SS PHY for Qualcomm's QCS404 Jorge Ramirez-Ortiz
2018-12-07 9:55 ` [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings Jorge Ramirez-Ortiz
2018-12-20 9:52 ` Jorge Ramirez-Ortiz
2018-12-20 17:07 ` Rob Herring
2018-12-21 7:42 ` Jorge Ramirez
2018-12-20 17:05 ` Rob Herring
2018-12-20 17:37 ` Jack Pham
2018-12-21 7:40 ` Jorge Ramirez [this message]
2018-12-28 12:38 ` Jorge Ramirez
2019-01-07 20:26 ` Jack Pham
2019-01-07 20:33 ` Andy Gross
2018-12-20 20:25 ` Stephen Boyd
2018-12-21 7:37 ` Jorge Ramirez
2018-12-26 17:55 ` Jorge Ramirez
2018-12-07 9:55 ` [PATCH 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver Jorge Ramirez-Ortiz
2018-12-20 20:29 ` Stephen Boyd
2018-12-26 17:53 ` Jorge Ramirez
2019-01-03 23:30 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3107e7b1-7d5f-8a67-34ec-e2d6f31cb28f@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh@kernel.org \
--cc=sallenki@codeaurora.org \
--cc=shawn.guo@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).