From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6641C7EE22 for ; Sun, 7 May 2023 08:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229872AbjEGIOn (ORCPT ); Sun, 7 May 2023 04:14:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbjEGIOm (ORCPT ); Sun, 7 May 2023 04:14:42 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8E31EE for ; Sun, 7 May 2023 01:14:40 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-50bd875398dso5166927a12.1 for ; Sun, 07 May 2023 01:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683447279; x=1686039279; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BxVB0qLFtd7CR9jihrYp0GNvnYgnGOXU77sZFAD78Ko=; b=lQ8wbMLMxVi1VNeZmvEyGYzKpbgaxtJnY28HvxU+BEBpZ8FeBnSDRICXtW3enFRIZA pr/+2Dbc42LGRxoVvPzwJ5MB2NCNxi6pnP6yDOw5nkjObjBpevlnW9dKBoPn/K1SXCNT pkhW5N+8wz+VhFeGfFiIIRLNp+7qS/lEHO9IdaIr/LJt5W3vVc/ac9xyDy6bHIbnAhwP LPOExGfZozKbRdkDhUGQScJcMXCnWvVSJKZIfus1RCMuOw9jTFa5bLdAwgZ0XGBmXNHJ 7Po5KPeAc60TPxTfQhevXE2pqJwaxwip5zQNhfxwMTO9LZDKT9D1zxUgiob69Al82Kcc JqLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683447279; x=1686039279; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BxVB0qLFtd7CR9jihrYp0GNvnYgnGOXU77sZFAD78Ko=; b=E2HIXl4jBIzxdIN3u36HJWLo2i3xffmHTorWpK90mAgA+k7HICYc5RUVG781bYKwGH 23gOmFoMgaPe11d7YwlIdkgkJXKo8aNfX+gYm9TqEFCLUPpLOTV4az/pUFSLWZRZJCog WJEdi+8Y84tHmqNbSlXDh0d3zL/9P4c8PRmpJMQsR9wkxFtD5PWhaOey8yo9Q3P07yR2 ZM0uq4IK05F3pmjjWY92RtR7K2KsKMXq4vDEbUdP4XCEDlEeQGHCsoVrQcMs8tPi2QGV eM3osFdZREcnAzV6Qh8Ff7aU5cQZjCQq7hBtBOD/m8+6iwU69LlrLYvth4KvJFS9gC5w 34zg== X-Gm-Message-State: AC+VfDyOfyWN+W+W0FwZtmAG8JhOXkE1QJsE6hrDMbNvy4qi/CHS/Juv AadDaBwHaSBhvV5H+N5ffo1H3A== X-Google-Smtp-Source: ACHHUZ6ylY1jyYRHzSyEND1iTejr0FcmzoLeOjgWmgkYfOXU4kIRdEKQmFEebU76i+rY1fPhrd2i9Q== X-Received: by 2002:a17:907:9444:b0:966:5730:c3fe with SMTP id dl4-20020a170907944400b009665730c3femr377381ejc.52.1683447279207; Sun, 07 May 2023 01:14:39 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:183b:950f:b4d5:135a? ([2a02:810d:15c0:828:183b:950f:b4d5:135a]) by smtp.gmail.com with ESMTPSA id h13-20020a1709070b0d00b0094efdfe60dcsm3287860ejl.206.2023.05.07.01.14.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 May 2023 01:14:38 -0700 (PDT) Message-ID: <31147c6d-e77a-8abd-0b55-73ead2385bb9@linaro.org> Date: Sun, 7 May 2023 10:14:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 03/12] dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375 Content-Language: en-US To: Konrad Dybcio , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Will Deacon , Robin Murphy , Joerg Roedel Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev References: <20230411-topic-straitlagoon_mdss-v3-0-9837d6b3516d@linaro.org> <20230411-topic-straitlagoon_mdss-v3-3-9837d6b3516d@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230411-topic-straitlagoon_mdss-v3-3-9837d6b3516d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/05/2023 23:40, Konrad Dybcio wrote: > SC7180, SM6350 and SM6375 use a rather similar hw setup for DPU, with > the main exception being that the last one requires an additional > throttle clock. > > It is not well understood yet, but failing to toggle it on makes the > display hardware stall and not output any frames. > > Document SM6350 and SM6375 DPU. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sc7180-dpu.yaml | 23 +++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml > index 1fb8321d9ee8..630b11480496 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-dpu.yaml > @@ -13,7 +13,10 @@ $ref: /schemas/display/msm/dpu-common.yaml# > > properties: > compatible: > - const: qcom,sc7180-dpu > + enum: > + - qcom,sc7180-dpu > + - qcom,sm6350-dpu > + - qcom,sm6375-dpu > > reg: > items: > @@ -26,6 +29,7 @@ properties: > - const: vbif > > clocks: > + minItems: 6 > items: > - description: Display hf axi clock > - description: Display ahb clock > @@ -33,8 +37,10 @@ properties: > - description: Display lut clock > - description: Display core clock > - description: Display vsync clock > + - description: Display core throttle clock > > clock-names: > + minItems: 6 > items: > - const: bus > - const: iface > @@ -42,6 +48,7 @@ properties: > - const: lut > - const: core > - const: vsync > + - const: throttle > > required: > - compatible > @@ -52,6 +59,20 @@ required: > > unevaluatedProperties: false > > +allOf: > + - if: > + properties: > + compatible: > + const: qcom,sm6375-dpu And the two other variants? Is the clock valid there or not? If not really, then you should have else: with maxItems: 6. > + > + then: > + properties: > + clocks: > + minItems: 7 > + > + clock-names: > + minItems: 7 If there is going new version - put allOf: before unevaluatedProperties:. Otherwise it is fine. > + > examples: > - | > #include > Best regards, Krzysztof