From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wangao Wang <quic_wangaow@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Qiwei Liu <quic_qiweil@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: x1e80100: add video node
Date: Wed, 3 Sep 2025 11:45:50 +0200 [thread overview]
Message-ID: <3117196e-782d-4ee3-b5a7-f0a87ae43bda@kernel.org> (raw)
In-Reply-To: <20250903-add_iris_for_x1e80100-v1-1-410e9e6c79f0@quicinc.com>
On 03/09/2025 10:27, Wangao Wang wrote:
> Add the IRIS video-codec node on X1E80100 platform to support video
> functionality.
>
> Signed-off-by: Wangao Wang <quic_wangaow@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 82 ++++++++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 737c5dbd1c808300041cc8897ca1f7450e16e019..aac40875e583fd49db85e1c5d0ca416cc02d0e5d 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -5186,6 +5186,88 @@ usb_1_ss1_dwc3_ss: endpoint {
> };
> };
>
> + iris: video-codec@aa00000 {
> + compatible = "qcom,x1e80100-iris", "qcom,sm8550-iris";
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-03 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 8:27 [PATCH 0/3] media: qcom: iris: add support for X1E80100 Wangao Wang
2025-09-03 8:27 ` [PATCH 1/3] arm64: dts: qcom: x1e80100: add video node Wangao Wang
2025-09-03 9:45 ` Krzysztof Kozlowski [this message]
2025-09-03 10:53 ` Konrad Dybcio
2025-09-03 8:27 ` [PATCH 2/3] arm64: dts: qcom: x1-crd: enable video Wangao Wang
2025-09-03 8:27 ` [PATCH 3/3] arm64: dts: qcom: hamoa-iot-evk: " Wangao Wang
2025-09-03 9:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3117196e-782d-4ee3-b5a7-f0a87ae43bda@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_qiweil@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=quic_wangaow@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).