devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rk3399: init vop clock rates
@ 2017-08-16  2:51 Kever Yang
       [not found] ` <1502851869-1736-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  2017-08-18 23:13 ` Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Kever Yang @ 2017-08-16  2:51 UTC (permalink / raw)
  To: heiko-4mtYJXux2i+zQB+pC5nmwQ
  Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Kever Yang,
	Douglas Anderson, William wu, Elaine Zhang, Brian Norris,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Shawn Lin,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jacob Chen,
	Will Deacon, Mark Rutland, Caesar Wang, Catalin Marinas,
	Roger Chen

We need to init vop aclk and hclk incase the U-Boot does not do
the initialize.

Signed-off-by: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---

 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 0b3acc9..a592c24 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1480,6 +1480,8 @@
 		interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH 0>;
 		clocks = <&cru ACLK_VOP1>, <&cru DCLK_VOP1>, <&cru HCLK_VOP1>;
 		clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
+		assigned-clocks = <&cru ACLK_VOP1>, <&cru HCLK_VOP1>;
+		assigned-clock-rates = <400000000>, <100000000>;
 		iommus = <&vopl_mmu>;
 		power-domains = <&power RK3399_PD_VOPL>;
 		resets = <&cru SRST_A_VOP1>, <&cru SRST_H_VOP1>, <&cru SRST_D_VOP1>;
@@ -1525,6 +1527,8 @@
 		interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH 0>;
 		clocks = <&cru ACLK_VOP0>, <&cru DCLK_VOP0>, <&cru HCLK_VOP0>;
 		clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
+		assigned-clocks = <&cru ACLK_VOP0>, <&cru HCLK_VOP0>;
+		assigned-clock-rates = <400000000>, <100000000>;
 		iommus = <&vopb_mmu>;
 		power-domains = <&power RK3399_PD_VOPB>;
 		resets = <&cru SRST_A_VOP0>, <&cru SRST_H_VOP0>, <&cru SRST_D_VOP0>;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rk3399: init vop clock rates
       [not found] ` <1502851869-1736-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
@ 2017-08-16  3:15   ` Mark yao
  0 siblings, 0 replies; 3+ messages in thread
From: Mark yao @ 2017-08-16  3:15 UTC (permalink / raw)
  To: Kever Yang, heiko-4mtYJXux2i+zQB+pC5nmwQ
  Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Elaine Zhang,
	Jacob Chen, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Shawn Lin,
	Brian Norris, Will Deacon, Douglas Anderson,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
	Roger Chen, Catalin Marinas, William wu,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Caesar Wang

On 2017年08月16日 10:51, Kever Yang wrote:
> We need to init vop aclk and hclk incase the U-Boot does not do
> the initialize.
>
> Signed-off-by: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---

Looks good for me:
     Reviewed-by: Mark Yao <mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 0b3acc9..a592c24 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1480,6 +1480,8 @@
>   		interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH 0>;
>   		clocks = <&cru ACLK_VOP1>, <&cru DCLK_VOP1>, <&cru HCLK_VOP1>;
>   		clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
> +		assigned-clocks = <&cru ACLK_VOP1>, <&cru HCLK_VOP1>;
> +		assigned-clock-rates = <400000000>, <100000000>;
>   		iommus = <&vopl_mmu>;
>   		power-domains = <&power RK3399_PD_VOPL>;
>   		resets = <&cru SRST_A_VOP1>, <&cru SRST_H_VOP1>, <&cru SRST_D_VOP1>;
> @@ -1525,6 +1527,8 @@
>   		interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH 0>;
>   		clocks = <&cru ACLK_VOP0>, <&cru DCLK_VOP0>, <&cru HCLK_VOP0>;
>   		clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
> +		assigned-clocks = <&cru ACLK_VOP0>, <&cru HCLK_VOP0>;
> +		assigned-clock-rates = <400000000>, <100000000>;
>   		iommus = <&vopb_mmu>;
>   		power-domains = <&power RK3399_PD_VOPB>;
>   		resets = <&cru SRST_A_VOP0>, <&cru SRST_H_VOP0>, <&cru SRST_D_VOP0>;


-- 
Mark Yao


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rk3399: init vop clock rates
  2017-08-16  2:51 [PATCH] arm64: dts: rk3399: init vop clock rates Kever Yang
       [not found] ` <1502851869-1736-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
@ 2017-08-18 23:13 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2017-08-18 23:13 UTC (permalink / raw)
  To: Kever Yang
  Cc: linux-rockchip, Douglas Anderson, William wu, Elaine Zhang,
	Brian Norris, linux-kernel, Shawn Lin, devicetree, Rob Herring,
	linux-arm-kernel, Jacob Chen, Will Deacon, Mark Rutland,
	Caesar Wang, Catalin Marinas, Roger Chen

Am Mittwoch, 16. August 2017, 10:51:09 CEST schrieb Kever Yang:
> We need to init vop aclk and hclk incase the U-Boot does not do
> the initialize.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>

applied for 4.14 with Marks review-tag after adapting the patch subject
and moving the properties slight higher


Thanks
Heiko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-18 23:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-16  2:51 [PATCH] arm64: dts: rk3399: init vop clock rates Kever Yang
     [not found] ` <1502851869-1736-1-git-send-email-kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-16  3:15   ` Mark yao
2017-08-18 23:13 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).