From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 4/6] dts: exynos: add device tree support for exynos5 hdmiddc Date: Tue, 16 Oct 2012 11:04:45 +0200 Message-ID: <3121613.V3YAufub0o@amdc1227> References: <1350343834-23992-1-git-send-email-rahul.sharma@samsung.com> <1350343834-23992-5-git-send-email-rahul.sharma@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6169507403307105841==" Return-path: In-reply-to: <1350343834-23992-5-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Rahul Sharma Cc: t.stanislaws-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, joshi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, r.sh.open-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, prashanth.g-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, s.shirish-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: devicetree@vger.kernel.org This is a multi-part message in MIME format. --===============6169507403307105841== Content-type: multipart/alternative; boundary=nextPart3744466.G259jCH1OU Content-transfer-encoding: 7Bit This is a multi-part message in MIME format. --nextPart3744466.G259jCH1OU Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, On Tuesday 16 of October 2012 05:00:32 Rahul Sharma wrote: > This patch adds support for device tree based discovery for exynos5 > hdmi ddc. > > Signed-off-by: Rahul Sharma > --- > .../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ++++++++++++ > arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +++++++++- > arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ > 3 files changed, 23 insertions(+), 1 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt > > diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt > b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt new file > mode 100644 > index 0000000..c408892 > --- /dev/null > +++ b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt > @@ -0,0 +1,12 @@ > +Device-Tree bindings for hdmiddc driver > + > +Required properties: > +- compatible: value should be "samsung,exynos5-hdmiddc". > +- reg: I2C address of the hdmiddc device. > + > +Example: > + > + hdmiddc { > + compatible = "samsung,exynos5-hdmiddc"; > + reg = <0x50>; > + }; > \ No newline at end of file > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts > b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 18ac213..f7b4fc4 > 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -56,7 +56,15 @@ > }; > > i2c@12C80000 { > - status = "disabled"; > + samsung,i2c-sda-delay = <100>; > + samsung,i2c-max-bus-freq = <66000>; > + gpios = <&gpa0 6 3 3 0>, > + <&gpa0 7 3 3 0>; > + > + hdmiddc@50 { > + compatible = "samsung,exynos5-hdmiddc"; > + reg = <0x50>; > + }; > }; > > i2c@12C90000 { > diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c > b/arch/arm/mach-exynos/mach-exynos5-dt.c index 3f129db..003963c 100644 > --- a/arch/arm/mach-exynos/mach-exynos5-dt.c > +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c > @@ -47,6 +47,8 @@ static const struct of_dev_auxdata > exynos5250_auxdata_lookup[] __initconst = { "s3c2440-i2c.0", NULL), > OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(1), > "s3c2440-i2c.1", NULL), > + OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(2), > + "s3c2440-i2c.2", NULL), > OF_DEV_AUXDATA("samsung,s3c2440-hdmiphy-i2c", EXYNOS5_PA_IIC(8), > "s3c2440-hdmiphy-i2c", NULL), > OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI0, Looks fine. Reviewed-by: Tomasz Figa Best regards, -- Tomasz Figa Samsung Poland R&D Center --nextPart3744466.G259jCH1OU Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii"

Hi,

 

On Tuesday 16 of October 2012 05:00:32 Rahul Sharma wrote:

> This patch adds support for device tree based discovery for exynos5

> hdmi ddc.

>

> Signed-off-by: Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

> ---

> .../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ++++++++++++

> arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +++++++++-

> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++

> 3 files changed, 23 insertions(+), 1 deletions(-)

> create mode 100644

> Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt

>

> diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt

> b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt new file

> mode 100644

> index 0000000..c408892

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt

> @@ -0,0 +1,12 @@

> +Device-Tree bindings for hdmiddc driver

> +

> +Required properties:

> +- compatible: value should be "samsung,exynos5-hdmiddc".

> +- reg: I2C address of the hdmiddc device.

> +

> +Example:

> +

> + hdmiddc {

> + compatible = "samsung,exynos5-hdmiddc";

> + reg = <0x50>;

> + };

> \ No newline at end of file

> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts

> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 18ac213..f7b4fc4

> 100644

> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts

> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts

> @@ -56,7 +56,15 @@

> };

>

> i2c@12C80000 {

> - status = "disabled";

> + samsung,i2c-sda-delay = <100>;

> + samsung,i2c-max-bus-freq = <66000>;

> + gpios = <&gpa0 6 3 3 0>,

> + <&gpa0 7 3 3 0>;

> +

> + hdmiddc@50 {

> + compatible = "samsung,exynos5-hdmiddc";

> + reg = <0x50>;

> + };

> };

>

> i2c@12C90000 {

> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c

> b/arch/arm/mach-exynos/mach-exynos5-dt.c index 3f129db..003963c 100644

> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c

> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c

> @@ -47,6 +47,8 @@ static const struct of_dev_auxdata

> exynos5250_auxdata_lookup[] __initconst = { "s3c2440-i2c.0", NULL),

> OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(1),

> "s3c2440-i2c.1", NULL),

> + OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(2),

> + "s3c2440-i2c.2", NULL),

> OF_DEV_AUXDATA("samsung,s3c2440-hdmiphy-i2c", EXYNOS5_PA_IIC(8),

> "s3c2440-hdmiphy-i2c", NULL),

> OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI0,

 

Looks fine.

 

Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

 

Best regards,

--

Tomasz Figa

Samsung Poland R&D Center

 

--nextPart3744466.G259jCH1OU-- --===============6169507403307105841== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============6169507403307105841==--