From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs Date: Thu, 27 Nov 2014 22:56:32 +0100 Message-ID: <3124625.mkxyU0zW0C@wuerfel> References: <1416447994-9921-1-git-send-email-mark.yao@rock-chips.com> <5476CDF7.60208@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Kurtz Cc: Mark yao , Dave Airlie , Joerg Roedel , Heiko =?ISO-8859-1?Q?St=FCbner?= , Boris BREZILLON , Rob Clark , Daniel Vetter , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Grant Likely , Greg Kroah-Hartman , John Stultz , Rom Lemarchand , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , dri-devel , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, open list:ARM/Rockch List-Id: devicetree@vger.kernel.org On Thursday 27 November 2014 14:05:00 Daniel Kurtz wrote: > On Thu, Nov 27, 2014 at 2:08 AM, Mark yao w= rote: > > > > On 2014=E5=B9=B411=E6=9C=8827=E6=97=A5 10:12, Dave Airlie wrote: > >>>> > >>>> > >>> Hi Dave > >>> Do you mean that I need send you a branch, based on drm-next= , merge with > >>> iommu tree and rockchip drm? > >> > >> Yes, grab drm-next, git pull the arm/rockchip branch from Joerg's > >> tree, put rockchip drm > >> patches on top, send me pull request. > >> > >> I'll validate it then. > >> > >> Dave. > >> > > Hi Dave > > I have send a pull request to you, with Joerg's iommu arm/rockc= hip branch. > > > > I got a same problem when use "make multi_v7_defconfig" as Heik= o said: > > drivers/video/fbdev/Kconfig:5:error: recursive dependency d= etected! > > drivers/video/fbdev/Kconfig:5: symbol FB is selected by = DRM_KMS_FB_HELPER > > drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER is = selected by DRM_ROCKCHIP > > drivers/gpu/drm/rockchip/Kconfig:1: symbol DRM_ROCKCHIP = depends on ARM_DMA_USE_IOMMU > > arch/arm/Kconfig:95: symbol ARM_DMA_USE_IOMMU is selecte= d by VIDEO_OMAP3 > > drivers/media/platform/Kconfig:96: symbol VIDEO_OMAP3 de= pends on VIDEO_V4L2 > > drivers/media/v4l2-core/Kconfig:6: symbol VIDEO_V4L2 dep= ends on I2C > > drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC > > drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selecte= d by FB_CYBER2000_DDC > > drivers/video/fbdev/Kconfig:374: symbol FB_CYBER2000_DDC= depends on FB_CYBER2000 > > drivers/video/fbdev/Kconfig:362: symbol FB_CYBER2000 dep= ends on FB > > > > I was confused how to solve the recursive dependency, remove de= pends on ARM_DMA_USE_IOMMU & IOMMU_API? >=20 > The "depends on ARM_DMA_USE_IOMMU & IOMMU_API" was suggested by Arnd > Bergmann during code review (originally they were selected). >=20 > Removing them definitely fixes the dependency recursion. > Also, since they are both already selected by ROCKCHIP_IOMMU, > everything will build correctly. > So, this sounds good to me, but I am no expert on Kconfig. >=20 I think the problem here is VIDEO_OMAP3 (among others), it should do th= e same as rockchips and use 'depends on' instead of 'select'. Another problem is the 'select I2C' in FB_DDC, but that would be much h= arder to fix. Arnd