From: Krzysztof Kozlowski <krzk@kernel.org>
To: Stanislav Jakubek <stano.jakubek@gmail.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: ti,tmp108: document V+ supply, add short description
Date: Mon, 17 Jun 2024 08:16:22 +0200 [thread overview]
Message-ID: <312d0bf2-3a17-44df-8a42-0168b2e3640a@kernel.org> (raw)
In-Reply-To: <Zm/FF2xX/rhwmLZ6@standask-GA-A55M-S2HP>
On 17/06/2024 07:09, Stanislav Jakubek wrote:
> On Sun, Jun 16, 2024 at 01:43:08PM -0700, Guenter Roeck wrote:
>> On 6/16/24 12:40, Stanislav Jakubek wrote:
>>> TMP108 is powered by its V+ supply, document it.
>>> While at it, add a short description with a link to its datasheets.
>>>
>>> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
>>> ---
>>> Not entirely sure of the "v+-supply" name, but the datasheet only ever
>>> refers to it as "V+" or simply as the "supply voltage".
>>> Only other name I've seen is in the schematic for the msm8226-based
>>> motorola-falcon smartphone, where it's called "V_POS".
>>>
>>
>> Guess one has to praise the ability of datasheet writers to come up
>> with different names.
>>
>> The datasheet for tmp117 also uses the V+ term, yet the supply name
>> is "vcc-supply". I would personally very much prefer to stick with that,
>> but that is just my personal opinion.
>>
>> Guenter
>>
>
> I'm okay with that. I'll keep this for a few days to see if anyone else
> has anything to say, then I'll send a V2 with it changed to vcc.
vcc. Anyway + is not an expected character.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-17 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 19:40 [PATCH] dt-bindings: hwmon: ti,tmp108: document V+ supply, add short description Stanislav Jakubek
2024-06-16 20:43 ` Guenter Roeck
2024-06-17 5:09 ` Stanislav Jakubek
2024-06-17 6:16 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312d0bf2-3a17-44df-8a42-0168b2e3640a@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=stano.jakubek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).