Re: [PATCH 3/4] dt-bindings: mfd: Add bindings for Samsung SysMgr

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/07/2022 06:56, Dongjin Yang wrote:
> Add an devicetree binding for Samsung system manager.
> This driver is used for SoCs produced by Samsung Foundry to provide
> Samsung sysmgr API. The read/write request of sysmgr is delivered to
> Samsung secure monitor call.

Nope. Second patch with the same - you need to describe the hardware or
underlying firmware, not the driver. "This driver" is not acceptable for
bindings.

> 
> Signed-off-by: Dongjin Yang <dj76.yang@samsung.com>
> ---
>  .../devicetree/bindings/mfd/samsung,sys-mgr.yaml   | 42 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml b/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
> new file mode 100644
> index 000000000000..83b9d73a5420
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/samsung,sys-mgr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung System Manager
> +
> +maintainers:
> +  - Jesper Nilsson <jesper.nilsson@axis.com>

How is this related to Axis platforms?

> +
> +description: |
> +  The file documents device tree bindings of Samsung system manager.

Useless description. Describe the hardw

> +
> +properties:
> +  compatible:
> +    enum:
> +      - samsung,sys-mgr
> +      - samsung,sys-mgr-smccc

Sorry, this does not look like hardware. It could be description of
underlying firmware, but you would need to justify it. Look at Qualcomm
SCM for example. Or ARM SCMI, SCPI.


Best regards,
Krzysztof