From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC54C07E9B for ; Sun, 11 Jul 2021 13:38:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66A51613E0 for ; Sun, 11 Jul 2021 13:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232775AbhGKNlf (ORCPT ); Sun, 11 Jul 2021 09:41:35 -0400 Received: from gloria.sntech.de ([185.11.138.130]:52982 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231658AbhGKNlf (ORCPT ); Sun, 11 Jul 2021 09:41:35 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2ZfQ-0007Ul-TE; Sun, 11 Jul 2021 15:38:44 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Jonathan Cameron , Simon Xue Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, Johan Jonker , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Simon Xue Subject: Re: [PATCH v1 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Date: Sun, 11 Jul 2021 15:38:44 +0200 Message-ID: <3140115.MfA8il8Al2@diego> In-Reply-To: <20210705012552.3781-1-xxm@rock-chips.com> References: <20210705012526.3731-1-xxm@rock-chips.com> <20210705012552.3781-1-xxm@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Montag, 5. Juli 2021, 03:25:52 CEST schrieb Simon Xue: > It is similar to other devices, but with 8 channels. > > Signed-off-by: Simon Xue Reviewed-by: Heiko Stuebner > --- > drivers/iio/adc/rockchip_saradc.c | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > index 12584f1631d8..f3eb8d2e50dc 100644 > --- a/drivers/iio/adc/rockchip_saradc.c > +++ b/drivers/iio/adc/rockchip_saradc.c > @@ -35,7 +35,7 @@ > #define SARADC_DLY_PU_SOC_MASK 0x3f > > #define SARADC_TIMEOUT msecs_to_jiffies(100) > -#define SARADC_MAX_CHANNELS 6 > +#define SARADC_MAX_CHANNELS 8 > > struct rockchip_saradc_data { > const struct iio_chan_spec *channels; > @@ -192,6 +192,23 @@ static const struct rockchip_saradc_data rk3399_saradc_data = { > .clk_rate = 1000000, > }; > > +static const struct iio_chan_spec rockchip_rk3568_saradc_iio_channels[] = { > + SARADC_CHANNEL(0, "adc0", 10), > + SARADC_CHANNEL(1, "adc1", 10), > + SARADC_CHANNEL(2, "adc2", 10), > + SARADC_CHANNEL(3, "adc3", 10), > + SARADC_CHANNEL(4, "adc4", 10), > + SARADC_CHANNEL(5, "adc5", 10), > + SARADC_CHANNEL(6, "adc6", 10), > + SARADC_CHANNEL(7, "adc7", 10), > +}; > + > +static const struct rockchip_saradc_data rk3568_saradc_data = { > + .channels = rockchip_rk3568_saradc_iio_channels, > + .num_channels = ARRAY_SIZE(rockchip_rk3568_saradc_iio_channels), > + .clk_rate = 1000000, > +}; > + > static const struct of_device_id rockchip_saradc_match[] = { > { > .compatible = "rockchip,saradc", > @@ -202,6 +219,9 @@ static const struct of_device_id rockchip_saradc_match[] = { > }, { > .compatible = "rockchip,rk3399-saradc", > .data = &rk3399_saradc_data, > + }, { > + .compatible = "rockchip,rk3568-saradc", > + .data = &rk3568_saradc_data, > }, > {}, > }; >