From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B33E38D417 for ; Thu, 11 Jun 2026 10:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781175203; cv=none; b=l9I0L08wnqqH33z6AxGQXmchly0SD3+IAB9msMvObhsoBUP0t4SK+13iCI5vgPFBBEK/+BtIbj3JaQvEMBdGb2WYIjqGvgeLxwS/AMprctAfokwj9K4ewGexEGMy+ctrEn5zBok/7l7n/Z9iDS7jxSIoc/BAIOprdvgv6CnFHWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781175203; c=relaxed/simple; bh=BJDKUiivYZYWopkDeJb+zwRxy3QE3nD0PUSgn8cPFqg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B2FVmEFOU+hAi4+fGIexSzODAMpweBwWCkLQ9mv+mK79cyoWwZZYpXk/Z3Q9L0YHogGKRtweL2acfpKfDYpgQfTM9m/Yv9PawVCQXuT9MekR9iO6VQb5AurwP4h5v7aGmSHtqjdfehzoYMquHo1JCUaZOJmRteT/3uKmQv5lSW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tez7sVvj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hpWd25uQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tez7sVvj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hpWd25uQ" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B9xV5J284927 for ; Thu, 11 Jun 2026 10:53:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5H/Mo3pv6k4BUmxPdQoFJDY6CLXDilJ24ACCV/rNsgg=; b=Tez7sVvjXKMJM597 h/kSafLPdTUaO1+veECvcjPcM1sBbSbD8KDbzODU+DjHuZKRkVA+NlWL+AzA40dZ jvHF/LYX7AfASoqj8R1xtI2G33Z2FC6lRZmK3N6u8hHKZIjIbtaBj9PFpOJPU2Hz BxP/1uUUC9UHdpEOZU9dVR1vD1UBEiW2TXE6xNdEoyN1NU3IZji7qNg5eMazBvSA RRkK2BfWUnD6HQXBXC/bpp98G7zK6smAVmPV2Fu4fPlyfUL7AGoHKI1FzYSmWH56 ARi/aEyArsHIaMD8YN3JiqFr89AuCcUURt2wPB+OO/m0DzwwFo7eaUhxETRAB6ua tHiuSg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6tk26g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 10:53:21 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2bf3636d6c0so82647805ad.2 for ; Thu, 11 Jun 2026 03:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781175201; x=1781780001; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5H/Mo3pv6k4BUmxPdQoFJDY6CLXDilJ24ACCV/rNsgg=; b=hpWd25uQ6EPUSiXdQMn6i8LQSD5yP7Z5EzfpLozq5KDgFP8maf06wzgx0qlvansYOt e6vuWNUHXzNwvRZqbCCO5C62cNO5lR//nEtD1c8sO/TppniiO9EthllXCgdABzVDf5j/ L5QZRKls8cXoSwivcl4aKkFNKER/3pWdy1kQ03jVA/OljpEiR7rnkideicHHZWw5eTDH FcAnDm28XgXEgHTqhQ/INu48tS3FpmKbEtsDJT07sR9gP4CI6rmhlHb0OoLTIUgGbWB0 5Uz9Ds5X5yA6meLwh9DbXWaw/Hi5baSO5VHx1SJ0jxxw9hjSDeTwrwOAWzd/guYUiIQ9 IVyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781175201; x=1781780001; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5H/Mo3pv6k4BUmxPdQoFJDY6CLXDilJ24ACCV/rNsgg=; b=bJHjK2SS9xNNwUFFLPv5Sw4PYVVznmPxOONzRaXPRC4m5diDDDY/hV6RUAruxsqtWx YVoC/J9G3wSTTxGxBNowFi0zc9cJU7ECMo3U4/OMDnWqSDP+/0+gkOCUsqqoO9ZMPOHf 8JzetHkaIHFhbgg0dwS9eK/i16nBWU3P8XDWoPopEVi7J718iV3vhDoF4uRdhwOxiENE Aguh8M9zmmXofzZaf/f40qBwM79GpFvRIUlKNlul8fFuoMX7BumJg8zmu3FkcrADGnuQ Uh5c/S/RMK/7WMUsIxuE094HbOgBd+b1dmEHYkxOgcNuj/T5vv4LqoemTz291f1vrbNK eqyA== X-Forwarded-Encrypted: i=1; AFNElJ9TfBThTXpyX3/wu79TmPLLcbui++2mOdefup75O8Q8RnHvlH5Ntlfc557LQPclZ0NTE+rhRTI6fqRm@vger.kernel.org X-Gm-Message-State: AOJu0YxH/Jl4b0cliBguO64RvahCZYEHdTIjzpzYB/w9ohnsh+WtEZVQ 0BK9NEcbAqWZyLEOXtNVmqi2t7umtV3/RwM53UEgwItiWVDZ5VhP7+3Ez0sYaFOxqVCsq5mDOyj gZnC3HzIS2SaKEfCtfEHW+hUwtdo4gWRDQahdOOtM54xIk73jIenn1UhAItriWYMb X-Gm-Gg: Acq92OH4stduACWAVHzBGVTWaBXWaJMsqZkxUGKgx5gO2echYfN03QmoPbda2y1V6ZO 2HgtmKZd03Zr1YGlTQWatwkmE2G8YNjp52SQr36DBhIp7n4Lzw17FSgQhkgfQ6TwtNfk7z1XcUo F2qakoQ3xhyJQxHEj1RwaPZVkfxSlZc8WQFkSHhFHOMz1p6RBfFIYr9OB00Vneaf6RVc6SfyyZb y5Yb9egP003xufwv+xaawfQd4roFB8fl+9f2nOiZHrhfc5VY7tdLlVWGOtTB1WWR0CggFZElKcF Hd9SatvQNEur3RMxPY59w99OFTfA7uGWIt+zSBLWLzEsbaYVsmOtE0P1Ohl3Nmk8gCG+U+jLtU+ LFwOy+WY5LYezwYbr4GASNWAChYwHT5FmuFFZlwGxEybYNeCGMX5S8zeknUE= X-Received: by 2002:a17:90b:4d84:b0:367:b819:2214 with SMTP id 98e67ed59e1d1-377a4ab6f54mr2587770a91.13.1781175200943; Thu, 11 Jun 2026 03:53:20 -0700 (PDT) X-Received: by 2002:a17:90b:4d84:b0:367:b819:2214 with SMTP id 98e67ed59e1d1-377a4ab6f54mr2587743a91.13.1781175200493; Thu, 11 Jun 2026 03:53:20 -0700 (PDT) Received: from [10.218.5.114] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-843383197e5sm1663475b3a.52.2026.06.11.03.53.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 03:53:20 -0700 (PDT) Message-ID: <31525025-333e-4845-9dfa-df68a3df3752@oss.qualcomm.com> Date: Thu, 11 Jun 2026 16:22:35 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/4] clk: qcom: smd-rpm: Add missing RF_CLK1/RF_CLK2 clocks support on Agatti To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Brian Masney Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260608-shikra-gcc-rpmcc-clks-v5-0-94cefe092ee3@oss.qualcomm.com> <20260608-shikra-gcc-rpmcc-clks-v5-3-94cefe092ee3@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDEwOSBTYWx0ZWRfX56lzH0W2G5IH MFKNZ96KP4EuqSupW5JIxknft2wOsQXYHlk6K//18jiFECvng3ynGcnU2Uux9xA6LfvGej2BrDB VIDNiOP6jpvEZGrt4L4InuTlHP1Y3m4P12Fki5tPGMt0k/b/kvHnMLQEhHXtuvd/Lcv6eyw8w7t SKdRQgm6NCFgBi/1mumAM/yMlMI7pRgTcYcmGwXoRSgehiEiVAb9+iHjutvDP3/bhYBi2otsq4O 1Ajckk0eQ3JOIeI6Bp00bwPexeuIxrsjR6y6BHplThOB5lOh0OgEK76SU6ZpZWboMpUSD0RS3uu oy7jejW7Ov6slL7TrECJlm3BKoR8KtUeLu0N+/vFuVTsDI6krjx+HUrjjzFJqKypMZzbKKYHbmE sTSAKTCZH07Av1vzH5NZzuoQWLzsdFmBGzUKiif8sF4uUNd9iXnxj3E87bgh2q3ZujPCOZTTKCf qWoGTsAO9884v3tIabA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDEwOSBTYWx0ZWRfX8ev1AYvI9w/s zdB52TuwE1Y5dFw56hcq7u88atPA6yHELoJm9AmtTYUT+3Qf9weJ+AGK3hkM7nNvUSJLsCE1CgW sqYNjuOIrPJCNjCSDlMOrutmseypuQw= X-Authority-Analysis: v=2.4 cv=AaiB2XXG c=1 sm=1 tr=0 ts=6a2a93a1 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=XXr5AoNkCxhS8z1Gjs4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: HP1MKi64Lg5sAx8YdmxZpg6DQTmtx6Za X-Proofpoint-GUID: HP1MKi64Lg5sAx8YdmxZpg6DQTmtx6Za X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110109 On 11-06-2026 03:10 pm, Konrad Dybcio wrote: > On 6/8/26 2:21 PM, Imran Shaik wrote: >> Add support for missing RF_CLK1/RF_CLK2 clocks on Qualcomm Agatti (QCM2290) >> SoC. >> >> Signed-off-by: Imran Shaik >> --- >> drivers/clk/qcom/clk-smd-rpm.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c >> index 103db984a40b950bd33fba668a292be46af6326e..0b624ed4715c75042b92ec49c073b281533cace4 100644 >> --- a/drivers/clk/qcom/clk-smd-rpm.c >> +++ b/drivers/clk/qcom/clk-smd-rpm.c >> @@ -495,6 +495,7 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(rf_clk2, 5, 19200000); >> DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(rf_clk3, 6, 19200000); >> DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(ln_bb_clk, 8, 19200000); >> >> +DEFINE_CLK_SMD_RPM_XO_BUFFER_PREFIX(38m4_, rf_clk2, 5, 38400000); >> DEFINE_CLK_SMD_RPM_XO_BUFFER_PREFIX(38m4_, rf_clk3, 6, 38400000); >> >> DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(cxo_d0, 1, 19200000); >> @@ -1262,6 +1263,10 @@ static struct clk_smd_rpm *qcm2290_clks[] = { >> [RPM_SMD_QDSS_A_CLK] = &clk_smd_rpm_branch_qdss_a_clk, >> [RPM_SMD_LN_BB_CLK2] = &clk_smd_rpm_ln_bb_clk2, >> [RPM_SMD_LN_BB_CLK2_A] = &clk_smd_rpm_ln_bb_clk2_a, >> + [RPM_SMD_RF_CLK1] = &clk_smd_rpm_rf_clk1, >> + [RPM_SMD_RF_CLK1_A] = &clk_smd_rpm_rf_clk1_a, > > Is RF_CLK1 19.2 MHz (with the other RFCLKs being 38.4) on purpose? > Yes Konrad, as per the hardware connectivity, RF_CLK1 runs at 19.2 MHz, while the other RF clocks operate at 38.4 MHz. Thanks, Imran