From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E87022068B; Fri, 25 Apr 2025 20:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745612564; cv=none; b=NV1kzHyj9pA/0bU5ieUJ8doT0Vj64pgZwz6ZxQPaFDzTt3Pd2p0lnR8/KWG/YSy4M7XCAyqwOkdUMj/+juULfr0bZjrFAL1L35EaY+tqmWImHw+4RDyifcdOVWJEiWKE5ZQ3h5fqpl6wINuL+sGkTAPF1S3caQVZq1tOtkv6r58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745612564; c=relaxed/simple; bh=bATJzVwifgOG0vWWHb4+YrLxNmRXS/txfK2CTpuYFSE=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=PhDa7EqA1wiO2Q6x1jFNmnKmS4CLIMmC7D7yMjpVp2OUiSoL4nq8pJKpP616uyimn3s1hSg6BM/tqmw8/HEw4+89LQV6meji17pAUw9I7nwLRLUFfHwYgPBvC+GC02RkSyuyHTdrV3LFPiyk2Vyp56aKb/n3KV6JWa7xJZt/eJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mainlining.org; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=VRIAWQQp; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="VRIAWQQp" Received: from localhost (web.docker-mailserver_default [172.18.0.2]) by mail.mainlining.org (Postfix) with ESMTPSA id 697BFBBAD2; Fri, 25 Apr 2025 20:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mainlining.org; s=psm; t=1745612559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXbQSFgD4UwsPz7sUQSSNntiwkGqZ/+DXflo57ZiM5I=; b=VRIAWQQpSY1jIYydk8YDCqAmMBYaVVb557wH0buXtfezPSYpaqe/fUapYeD+EAG2sCGuxD 4WK3Ns7lGjgpH3tXDe0jVXfochXNnnUVts3CDSqsZ/T2H1wUGJQbRyAqL7b5K0OWWct9pf yDuqGydiSB6w+bHArYHmbNToR0J1/rSjYxaIixxPfqaqyfi5guot5tb6qp9f3v20qFu3l0 wkdvdxcB4F0OBYUjH3xDY3SKRLHFr3QBH2sYQDOAFPW3ts63YdAiQslu6MyFlm04QfiFvK hyrlsjYlVxj/I0PwhCuVhts7NvtHbYJFt8RYCBBF0DzO13HDMhgxcYPOHD3oAA== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 25 Apr 2025 22:22:39 +0200 From: barnabas.czeman@mainlining.org To: Konrad Dybcio Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , =?UTF-8?Q?Otto_Pfl=C3=BCger?= , Linus Walleij , Lee Jones , Joerg Roedel , Will Deacon , Robin Murphy , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Baryshkov , Adam Skladowski , Sireesh Kodali , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Dang Huynh Subject: Re: [PATCH v5 3/5] arm64: dts: qcom: Add initial support for MSM8937 In-Reply-To: <68e2c0ee-d5e2-40fd-9ca0-262ed3270628@oss.qualcomm.com> References: <20250421-msm8937-v5-0-bf9879ef14d9@mainlining.org> <20250421-msm8937-v5-3-bf9879ef14d9@mainlining.org> <2e3d94a4-d9e1-429e-9f65-d004c80180e5@oss.qualcomm.com> <790a0b7537e0b82b70bc4b32612ecee6@mainlining.org> <70635d75-03f9-49ea-8098-57cb144fda94@oss.qualcomm.com> <5ccb39f9393b44761127717096a38a46@mainlining.org> <68e2c0ee-d5e2-40fd-9ca0-262ed3270628@oss.qualcomm.com> Message-ID: <31559417a92d1e1ff17d0f3add9a1ba0@mainlining.org> X-Sender: barnabas.czeman@mainlining.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-04-25 21:26, Konrad Dybcio wrote: > On 4/25/25 5:13 PM, barnabas.czeman@mainlining.org wrote: >> On 2025-04-25 11:57, Konrad Dybcio wrote: >>> On 4/23/25 4:46 PM, barnabas.czeman@mainlining.org wrote: >>>> On 2025-04-23 16:03, Konrad Dybcio wrote: >>>>> On 4/21/25 10:18 PM, Barnabás Czémán wrote: >>>>>> From: Dang Huynh >>>>>> >>>>>> Add initial support for MSM8937 SoC. >>>>>> >>>>>> Signed-off-by: Dang Huynh >>>>>> Co-developed-by: Barnabás Czémán >>>>>> Signed-off-by: Barnabás Czémán >>>>>> --- >>> >>> [...] >>> >>>>>> +            gpu_opp_table: opp-table { >>>>>> +                compatible = "operating-points-v2"; >>>>>> + >>>>>> +                opp-19200000 { >>>>>> +                    opp-hz = /bits/ 64 <19200000>; >>>>>> +                    opp-supported-hw = <0xff>; >>>>> >>>>> The comment from the previous revision still stands >>>> If i remove opp-supported-hw i will got -22 EINVAL messages and the >>>> opp will be not fine. >>> >>> Right, I have a series pending to improve this situation a bit.. >>> >>> In the meantime, you should be able to define the nvmem cell and >>> fill in meaningful values for this platform >> As I wrote in the previous revision there is no nvmem for GPU on >> msm8937 only on msm8940. > > This seems not to be the case > > https://github.com/penglezos/android_kernel_xiaomi_msm8953/blob/pie/arch/arm/boot/dts/qcom/msm8937.dtsi#L2046-L2191 > These are on msm-4.9 was moved to msm8940.dtsi https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8937-gpu.dtsi#L162 https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8940.dtsi#L600 475 MHz and 500 MHz is for msm8940 at least based on 4.9 > Konrad