Re: [PATCH v3 04/14] drm/sun4i: hdmi: Use more portable I/O helpers

Jernej Škrabec
2022-04-24T19:59:50Z

Dne nedelja, 24. april 2022 ob 18:26:22 CEST je Samuel Holland napisal(a):
> readsb/writesb are unavailable on some architectures. In preparation for
> removing the Kconfig architecture dependency, switch to the equivalent
> but more portable ioread/write8_rep helpers.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej Skrabec

> ---
>
> (no changes since v2)
>
> Changes in v2:
> - New patch: I/O helper portability
>
> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i/
sun4i_hdmi_i2c.c
> index b66fa27fe6ea..c7d7e9fff91c 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c
> @@ -56,9 +56,9 @@ static int fifo_transfer(struct sun4i_hdmi *hdmi, u8 *buf,
int len, bool read)
> return -EIO;
>
> if (read)
> - readsb(hdmi->base + hdmi->variant->ddc_fifo_reg, buf,
len);
> + ioread8_rep(hdmi->base + hdmi->variant->ddc_fifo_reg,
buf, len);
> else
> - writesb(hdmi->base + hdmi->variant->ddc_fifo_reg, buf,
len);
> + iowrite8_rep(hdmi->base + hdmi->variant->ddc_fifo_reg,
buf, len);
>
> /* Clear FIFO request bit by forcing a write to that bit */
> regmap_field_force_write(hdmi->field_ddc_int_status,
> --
> 2.35.1
>
>