Re: (subset) [PATCH v3 08/14] sun4i/drm: sun8i: use mode_set engine callback

Maxime Ripard
2022-04-26T12:42:08Z

On Sun, 24 Apr 2022 11:26:26 -0500, Samuel Holland wrote:
> From: Jernej Skrabec <jernej.skrabec@gmail.com>
>
> Newly introduced mode_set callback in engine structure is a much better
> place for setting mixer output size and interlace mode for the following
> reasons:
> 1. Aforementioned properties change only when mode changes, so it's
> enough to be set only once per mode set. Currently it's done whenever
> properties of primary plane are changed.
> 2. It's assumed that primary plane will always cover whole screen. While
> this is true most of the time, it's not always. DE2/3 planes are
> universal and mostly equal in functionality. There is no reason to
> add artificial limitation to primary planes.
> 3. The current code only works for UI layers, but some mixers do not
> have any UI layers.
>
> [...]

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime