From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sarthak Garg <sarthak.garg@oss.qualcomm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_nguyenb@quicinc.com, quic_rampraka@quicinc.com,
quic_pragalla@quicinc.com, quic_sayalil@quicinc.com,
quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com,
kernel@oss.qualcomm.com
Subject: Re: [PATCH V3 2/4] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc
Date: Mon, 27 Oct 2025 15:32:23 +0100 [thread overview]
Message-ID: <3170ad12-0d79-4cb1-aedc-d2c9f1da366f@kernel.org> (raw)
In-Reply-To: <20251026111746.3195861-3-sarthak.garg@oss.qualcomm.com>
On 26/10/2025 12:17, Sarthak Garg wrote:
> Add SD Card host controller for sm8750 soc.
>
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sm8750.dtsi | 54 ++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index a82d9867c7cb..50e1fa67c093 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -2060,6 +2060,60 @@ ice: crypto@1d88000 {
> clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>;
> };
>
> + sdhc_2: mmc@8804000 {
Completely messed ordering.
> + compatible = "qcom,sm8750-sdhci", "qcom,sdhci-msm-v5";
> + reg = <0 0x08804000 0 0x1000>;
Use hex everywhere in reg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-27 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 11:17 [PATCH V3 0/4] Add SD Card support for sm8750 SoC and boards Sarthak Garg
2025-10-26 11:17 ` [PATCH V3 1/4] dt-bindings: mmc: sdhci-msm: Add sm8750 compatible Sarthak Garg
2025-10-27 14:30 ` Krzysztof Kozlowski
2025-11-10 6:47 ` Sarthak Garg
2025-11-10 7:08 ` Krzysztof Kozlowski
2025-11-10 14:58 ` Bjorn Andersson
2025-10-26 11:17 ` [PATCH V3 2/4] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 soc Sarthak Garg
2025-10-26 19:02 ` Abel Vesa
2025-10-27 14:32 ` Krzysztof Kozlowski [this message]
2025-11-10 7:06 ` Sarthak Garg
2025-11-10 7:09 ` Krzysztof Kozlowski
2025-10-26 11:17 ` [PATCH V3 3/4] arm64: dts: qcom: sm8750-mtp: Add SDC2 node for sm8750 mtp board Sarthak Garg
2025-10-27 14:31 ` Krzysztof Kozlowski
2025-10-27 14:33 ` Krzysztof Kozlowski
2025-11-10 8:47 ` Sarthak Garg
2025-10-26 11:17 ` [PATCH V3 4/4] arm64: dts: qcom: sm8750-qrd: Add SDC2 node for sm8750 qrd board Sarthak Garg
2025-10-27 14:34 ` Krzysztof Kozlowski
2025-11-10 8:48 ` Sarthak Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3170ad12-0d79-4cb1-aedc-d2c9f1da366f@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=robh@kernel.org \
--cc=sarthak.garg@oss.qualcomm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).