From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B53C64EC4 for ; Wed, 8 Mar 2023 16:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbjCHQb6 convert rfc822-to-8bit (ORCPT ); Wed, 8 Mar 2023 11:31:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjCHQbz (ORCPT ); Wed, 8 Mar 2023 11:31:55 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43A8E10421 for ; Wed, 8 Mar 2023 08:31:52 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pZwhM-0000cX-4d; Wed, 08 Mar 2023 17:31:28 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Krzysztof Kozlowski , Vasily Khoruzhick Cc: Rob Herring , Krzysztof Kozlowski , Jagan Teki , Peter Geis , Andy Yan , Chris Morgan , Nicolas Frattaroli , Brian Norris , Sebastian Reichel , Andrew Lunn , Michael Riesch , Maya Matuszczyk , Chukun Pan , Sascha Hauer , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Tianling Shen Subject: Re: [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R5S Date: Wed, 08 Mar 2023 17:31:36 +0100 Message-ID: <3188745.AJdgDx1Vlc@diego> In-Reply-To: References: <20230308063240.107178-1-anarsoul@gmail.com> <4204317f-6715-cdeb-343d-611aea0d554a@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Mittwoch, 8. März 2023, 17:09:20 CET schrieb Vasily Khoruzhick: > On Wed, Mar 8, 2023 at 3:31 AM Krzysztof Kozlowski > wrote: > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > index 35f74eda30ae..0813ad22dc76 100644 > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > > @@ -201,6 +201,11 @@ properties: > > > - friendlyarm,nanopi-r4s-enterprise > > > - const: rockchip,rk3399 > > > > > > + - description: FriendlyElec NanoPi R5S board > > > + > > > > Does not look like ordered alphabetically. Are you sure this is correct > > place for it? > > Hmm, strictly speaking, "FriendlyElec NanoPi R5S board" should go in > between of "FriendlyElec NanoPi R2S" and "FriendlyElec NanoPi4 series > boards" if we want it in alphabetical order, not after "FriendlyElec > NanoPi4 series boards" like in this patch. But it doesn't look nice > (because R5S will go before R4S). > > There is already similar ordering (alphabetical/chronological for > model) for Radxa Rock Pi - "Radxa ROCK Pi S", "Radxa Rock2 Square", > "Radxa ROCK3 Model A", "Radxa ROCK 5 Model A". > > However if you want me to sort it strictly alphabetically, I can send a v2. TL;DR: I think the entry is "just right" where it currently is :-) - FriendlyElec NanoPi R2S -> would become "FriendlyElec NanoPi2 series boards", _if_ there will ever be some others - FriendlyElec NanoPi R4S is included in the "FriendlyElec NanoPi4 series boards" and similarly the "FriendlyElec NanoPi R5S board" would become "FriendlyElec NanoPi5 boards" once they release more variants. [Though we could get rid of the "board" in the current entry] And judging by the amound of devices Pine64 did on the rk3568-base, I guess it's fairly likely that FriendlyArm will release more in the future as well, so the current position seems fitting. Heiko