From: Esteban Urrutia <esteuwu@proton.me>
To: Neil Armstrong <neil.armstrong@linaro.org>,
David Heidelberg <david@ixit.cz>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add bindings for Novatek NT37703
Date: Wed, 12 Aug 2026 20:10:48 +0000 [thread overview]
Message-ID: <318b749e-26db-4d74-b910-a368a9e51013@proton.me> (raw)
In-Reply-To: <05d2ad33-a681-41e4-87f7-e3aaeb5428a8@linaro.org>
On 8/12/26 7:52 AM, Neil Armstrong wrote:
> On 8/12/26 10:46, David Heidelberg wrote:
>> bit I missed in the review the part:
>>
>> + compatible = "motorola,bronco-tianma-v2-nt37703", "novatek,nt37703";
>>
>> Unless the driver is able to auto-detect the connected panel (unlikely), novatek,nt37703 doesn't make sense. The DDIC without the panel is useless.
>>
>> For example, in sdm845-oneplus-fajita and enchilada, we have the generic compatible because it was introduced before, so it's kept for compatibility reasons. There is no need to do that here.
>
> Yeah today the norm is to add the ddic as second compatible entry so the first compatible just describes the pane, so here it should be:
>
> compatible = "motorola,bronco-tianma-v2", "novatek,nt37703";
In that case first compatible string should be
"tianma,motorola-bronco-v2" since Tianma is the panel maker and this
"v2" panel is only used in motorola-bronco.
Regards,
Esteban
next prev parent reply other threads:[~2026-08-12 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 5:52 [PATCH 0/2] Add panel driver for Novatek NT37703 Esteban Urrutia via B4 Relay
2026-08-11 5:52 ` [PATCH 1/2] dt-bindings: display: panel: Add bindings " Esteban Urrutia via B4 Relay
2026-08-11 13:05 ` David Heidelberg
2026-08-12 5:21 ` Esteban Urrutia
2026-08-12 8:46 ` David Heidelberg
2026-08-12 11:52 ` Neil Armstrong
2026-08-12 12:15 ` David Heidelberg
2026-08-12 12:22 ` Neil Armstrong
2026-08-12 12:53 ` David Heidelberg
2026-08-12 14:29 ` Neil Armstrong
2026-08-12 20:10 ` Esteban Urrutia [this message]
2026-08-11 5:52 ` [PATCH 2/2] drm/panel: Add driver for Novatek NT37703 based panels Esteban Urrutia via B4 Relay
2026-08-11 14:28 ` Uwe Kleine-König
2026-08-12 11:55 ` Neil Armstrong
2026-08-12 20:05 ` Esteban Urrutia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=318b749e-26db-4d74-b910-a368a9e51013@proton.me \
--to=esteuwu@proton.me \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox