From: Krzysztof Kozlowski <krzk@kernel.org>
To: dj76.yang@samsung.com,
"jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
"lars.persson@axis.com" <lars.persson@axis.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "javierm@redhat.com" <javierm@redhat.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Moon-Ki Jun <moonki.jun@samsung.com>,
Sang Min Kim <hypmean.kim@samsung.com>,
Wangseok Lee <wangseok.lee@samsung.com>
Subject: Re: [PATCH 0/4] Add Samsung system manager and secure service
Date: Wed, 13 Jul 2022 09:42:12 +0200 [thread overview]
Message-ID: <3190164d-dcdb-6dd8-37c8-e1bb1128ef56@kernel.org> (raw)
In-Reply-To: <20220713045143epcms1p5483300a3cf9ed97308a1bcfe5b889a02@epcms1p5>
On 13/07/2022 06:51, Dongjin Yang wrote:
> Add Samsung System manager driver and Secure Service code.
> Samsung System manager is for SoCs produced by Samsung Foundry
> to provide system read/write request by System Manager API.
> Samsung Secure service is for SoCs produced by Samsung Foundry
> to provide secure monitor service using Trusted Foundations.
>
1. You need to provide users of these drivers. For the
syscon-regmap-export driver (better name than manager which does not
manager anything), having a user would answer the question why such
weird driver is needed. Since there is no user and driver's behavior
breaks design choices, it has to be NAKed.
2. Thread your submissions properly. Git send email does it
automatically for you. You can use other tools, but then be sure your
patches are properly threaded. This patchset was not which makes review
more difficult than it should.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-07-13 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220713045143epcms1p5483300a3cf9ed97308a1bcfe5b889a02@epcms1p5>
2022-07-13 4:51 ` [PATCH 0/4] Add Samsung system manager and secure service Dongjin Yang
2022-07-13 7:42 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3190164d-dcdb-6dd8-37c8-e1bb1128ef56@kernel.org \
--to=krzk@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dj76.yang@samsung.com \
--cc=hypmean.kim@samsung.com \
--cc=javierm@redhat.com \
--cc=jesper.nilsson@axis.com \
--cc=krzk+dt@kernel.org \
--cc=lars.persson@axis.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moonki.jun@samsung.com \
--cc=robh+dt@kernel.org \
--cc=wangseok.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).