From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E194C433EF for ; Wed, 13 Jul 2022 07:42:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234289AbiGMHmZ (ORCPT ); Wed, 13 Jul 2022 03:42:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230304AbiGMHmY (ORCPT ); Wed, 13 Jul 2022 03:42:24 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A0AE477A; Wed, 13 Jul 2022 00:42:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0EF24CE1DFF; Wed, 13 Jul 2022 07:42:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07023C34114; Wed, 13 Jul 2022 07:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657698140; bh=mHJcwUWhMboDxIfJdmt9WJ6y+0j5+D86+p+eDlzLAzY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GN09hmSRP/B7nNVf0Mq8WBcOW2iy/ywNO4lGPBWDa68dFXLauSqn0skWjsDZNhJ9Z LEt+LDWNkqcD2sd4M4T2qygvXGl+wnXfWiuSNeLpsPPOqQhyXQZRE1Wr+K0ayZU2mY o96svKncLM5hoY7AR0VBgTW8mJQDH3o3JkOrCqtwuRjtbYBFaOyAM6hfplG/OdRDVL 4mh1r9xgQoFg2bc0HjHnL5ibYrmjXCY7kHvSsAZRXELHMN/Alh+mat9t1wMGnoex9z JOhYWjWyGy3EjyOxfBiNSBbuViapOuYhn041DpYlWoYuhGzAPmKlfi5I/1WP8cSh0V 9cyu+ySS3tKqw== Message-ID: <3190164d-dcdb-6dd8-37c8-e1bb1128ef56@kernel.org> Date: Wed, 13 Jul 2022 09:42:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/4] Add Samsung system manager and secure service Content-Language: en-US To: dj76.yang@samsung.com, "jesper.nilsson@axis.com" , "lars.persson@axis.com" , "robh+dt@kernel.org" , "krzk+dt@kernel.org" , "lee.jones@linaro.org" Cc: "javierm@redhat.com" , "bjorn.andersson@linaro.org" , "linux-arm-kernel@axis.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Moon-Ki Jun , Sang Min Kim , Wangseok Lee References: <20220713045143epcms1p5483300a3cf9ed97308a1bcfe5b889a02@epcms1p5> From: Krzysztof Kozlowski In-Reply-To: <20220713045143epcms1p5483300a3cf9ed97308a1bcfe5b889a02@epcms1p5> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/07/2022 06:51, Dongjin Yang wrote: > Add Samsung System manager driver and Secure Service code. > Samsung System manager is for SoCs produced by Samsung Foundry > to provide system read/write request by System Manager API. > Samsung Secure service is for SoCs produced by Samsung Foundry > to provide secure monitor service using Trusted Foundations. > 1. You need to provide users of these drivers. For the syscon-regmap-export driver (better name than manager which does not manager anything), having a user would answer the question why such weird driver is needed. Since there is no user and driver's behavior breaks design choices, it has to be NAKed. 2. Thread your submissions properly. Git send email does it automatically for you. You can use other tools, but then be sure your patches are properly threaded. This patchset was not which makes review more difficult than it should. Best regards, Krzysztof