[PATCH 0/4] Add Samsung system manager and secure service

[PATCH 0/4] Add Samsung system manager and secure service

[Dongjin Yang]

Add Samsung System manager driver and Secure Service code.
Samsung System manager is for SoCs produced by Samsung Foundry
to provide system read/write request by System Manager API.
Samsung Secure service is for SoCs produced by Samsung Foundry
to provide secure monitor service using Trusted Foundations.

Dongjin Yang (4):
  dt-bindings: firmware: Add bindings for Samsung smc
  firmware: Samsung: Add secure monitor driver
  dt-bindings: mfd: Add bindings for Samsung SysMgr
  mfd: Samsung: Add Samsung sysmgr driver

 .../bindings/firmware/samsung,smccc-svc.yaml       |  31 ++++
 .../devicetree/bindings/mfd/samsung,sys-mgr.yaml   |  42 ++++++
 MAINTAINERS                                        |   6 +
 drivers/firmware/Kconfig                           |  11 ++
 drivers/firmware/Makefile                          |   1 +
 drivers/firmware/samsung-smc-svc.c                 | 154 +++++++++++++++++++
 drivers/mfd/Kconfig                                |  11 ++
 drivers/mfd/Makefile                               |   1 +
 drivers/mfd/samsung-sysmgr.c                       | 167 +++++++++++++++++++++
 include/linux/firmware/samsung-smc-svc.h           |  59 ++++++++
 include/linux/mfd/samsung-sysmgr.h                 |  30 ++++
 11 files changed, 513 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
 create mode 100644 Documentation/devicetree/bindings/mfd/samsung,sys-mgr.yaml
 create mode 100644 drivers/firmware/samsung-smc-svc.c
 create mode 100644 drivers/mfd/samsung-sysmgr.c
 create mode 100644 include/linux/firmware/samsung-smc-svc.h
 create mode 100644 include/linux/mfd/samsung-sysmgr.h

-- 
2.9.5

Re: [PATCH 0/4] Add Samsung system manager and secure service

[Krzysztof Kozlowski]

On 13/07/2022 06:51, Dongjin Yang wrote:
> Add Samsung System manager driver and Secure Service code.
> Samsung System manager is for SoCs produced by Samsung Foundry
> to provide system read/write request by System Manager API.
> Samsung Secure service is for SoCs produced by Samsung Foundry
> to provide secure monitor service using Trusted Foundations.
> 

1. You need to provide users of these drivers. For the
syscon-regmap-export driver (better name than manager which does not
manager anything), having a user would answer the question why such
weird driver is needed. Since there is no user and driver's behavior
breaks design choices, it has to be NAKed.

2. Thread your submissions properly. Git send email does it
automatically for you. You can use other tools, but then be sure your
patches are properly threaded. This patchset was not which makes review
more difficult than it should.

Best regards,
Krzysztof