From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Date: Fri, 05 Sep 2014 14:20:57 +0200 Message-ID: <31986364.cn091cmIXU@wuerfel> References: <1409928798-31895-1-git-send-email-alvin.chen@intel.com> <4656BEB6164FC34F8171C6538F1A595B2E9829DA@SHSMSX101.ccr.corp.intel.com> <1409918522.30155.89.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1409918522.30155.89.camel@intel.com> Sender: linux-gpio-owner@vger.kernel.org To: "Shevchenko, Andriy" Cc: "Chen, Alvin" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "Kweh, Hock Leong" , "sebastian@breakpoint.cc" , "devicetree@vger.kernel.org" , "Ong, Boon Leong" , "gnurou@gmail.com" , "linus.walleij@linaro.org" , "linux-gpio@vger.kernel.org" , "grant.likely@linaro.org" , "Westerberg, Mika" , "dvhart@linux.intel.com" , "atull@opensource.altera.com" List-Id: devicetree@vger.kernel.org On Friday 05 September 2014 12:02:01 Shevchenko, Andriy wrote: > > irq = irq_of_parse_and_map(node, 0); > > If (!irq) { > > pp->irq = -1; > > return; > > } else { > > pp->irq = irq; > > } > > Then the code looks strange. > > > > How do you think? > > If I understood correctly you messed up with hwirq vs. virq. > Otherwise you have mention that you are using virq everywhere (I guess > you may rename the field in the structure), but in this case the field > in the platform_data looks a bit strange. The field in platform_data should be the mapped virtual irq number, it makes no sense to use the hwirq unless you also add a pointer to the domain in which that hwirq exists. Also the output of irq_of_parse_and_map() is a mapped irq, as the name suggests. Arnd