* [PATCH v7 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings [not found] <20210303081158.684532-1-steen.hegelund@microchip.com> @ 2021-03-03 8:11 ` Steen Hegelund 2021-03-03 8:11 ` [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver Steen Hegelund 1 sibling, 0 replies; 5+ messages in thread From: Steen Hegelund @ 2021-03-03 8:11 UTC (permalink / raw) To: Philipp Zabel, Rob Herring Cc: Steen Hegelund, Andrew Lunn, Microchip Linux Driver Support, Alexandre Belloni, Gregory Clement, linux-kernel, linux-arm-kernel, devicetree Document the Sparx5 reset device driver bindings The driver uses a syscon and an IO range on sparx5 for access to the reset control and the reset status. Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> --- .../bindings/reset/microchip,rst.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/reset/microchip,rst.yaml diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml new file mode 100644 index 000000000000..370579aeeca1 --- /dev/null +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/reset/microchip,rst.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Microchip Sparx5 Switch Reset Controller + +maintainers: + - Steen Hegelund <steen.hegelund@microchip.com> + - Lars Povlsen <lars.povlsen@microchip.com> + +description: | + The Microchip Sparx5 Switch provides reset control and implements the following + functions + - One Time Switch Core Reset (Soft Reset) + +properties: + $nodename: + pattern: "^reset-controller@[0-9a-f]+$" + + compatible: + const: microchip,sparx5-switch-reset + + reg: + items: + - description: global control block registers + + reg-names: + items: + - const: gcb + + "#reset-cells": + const: 1 + + cpu-syscon: + $ref: "/schemas/types.yaml#/definitions/phandle" + description: syscon used to access CPU reset + +required: + - compatible + - reg + - reg-names + - "#reset-cells" + - cpu-syscon + +additionalProperties: false + +examples: + - | + reset: reset-controller@11010008 { + compatible = "microchip,sparx5-switch-reset"; + reg = <0x11010008 0x4>; + reg-names = "gcb"; + #reset-cells = <1>; + cpu-syscon = <&cpu_ctrl>; + }; + -- 2.30.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver [not found] <20210303081158.684532-1-steen.hegelund@microchip.com> 2021-03-03 8:11 ` [PATCH v7 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings Steen Hegelund @ 2021-03-03 8:11 ` Steen Hegelund 2021-03-03 8:56 ` Alexandre Belloni 2021-03-08 19:59 ` Rob Herring 1 sibling, 2 replies; 5+ messages in thread From: Steen Hegelund @ 2021-03-03 8:11 UTC (permalink / raw) To: Philipp Zabel, Rob Herring Cc: Steen Hegelund, Andrew Lunn, Microchip Linux Driver Support, Alexandre Belloni, Gregory Clement, linux-kernel, linux-arm-kernel, devicetree This provides reset driver support for the Microchip Sparx5 PCB134 and PCB135 reference boards. Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi index 380281f312d8..dc3ada5cf9fc 100644 --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi @@ -132,9 +132,12 @@ mux: mux-controller { }; }; - reset@611010008 { - compatible = "microchip,sparx5-chip-reset"; + reset: reset-controller@611010008 { + compatible = "microchip,sparx5-switch-reset"; reg = <0x6 0x11010008 0x4>; + reg-names = "gcb"; + #reset-cells = <1>; + cpu-syscon = <&cpu_ctrl>; }; uart0: serial@600100000 { -- 2.30.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver 2021-03-03 8:11 ` [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver Steen Hegelund @ 2021-03-03 8:56 ` Alexandre Belloni 2021-03-08 19:59 ` Rob Herring 1 sibling, 0 replies; 5+ messages in thread From: Alexandre Belloni @ 2021-03-03 8:56 UTC (permalink / raw) To: Steen Hegelund Cc: Philipp Zabel, Rob Herring, Andrew Lunn, Microchip Linux Driver Support, Gregory Clement, linux-kernel, linux-arm-kernel, devicetree On 03/03/2021 09:11:58+0100, Steen Hegelund wrote: > This provides reset driver support for the Microchip Sparx5 PCB134 and > PCB135 reference boards. > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > arch/arm64/boot/dts/microchip/sparx5.dtsi | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi > index 380281f312d8..dc3ada5cf9fc 100644 > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > @@ -132,9 +132,12 @@ mux: mux-controller { > }; > }; > > - reset@611010008 { > - compatible = "microchip,sparx5-chip-reset"; > + reset: reset-controller@611010008 { > + compatible = "microchip,sparx5-switch-reset"; > reg = <0x6 0x11010008 0x4>; > + reg-names = "gcb"; > + #reset-cells = <1>; > + cpu-syscon = <&cpu_ctrl>; > }; > > uart0: serial@600100000 { > -- > 2.30.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver 2021-03-03 8:11 ` [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver Steen Hegelund 2021-03-03 8:56 ` Alexandre Belloni @ 2021-03-08 19:59 ` Rob Herring 2021-03-16 8:36 ` Steen Hegelund 1 sibling, 1 reply; 5+ messages in thread From: Rob Herring @ 2021-03-08 19:59 UTC (permalink / raw) To: Steen Hegelund Cc: Philipp Zabel, Andrew Lunn, Microchip Linux Driver Support, Alexandre Belloni, Gregory Clement, linux-kernel, linux-arm-kernel, devicetree On Wed, Mar 03, 2021 at 09:11:58AM +0100, Steen Hegelund wrote: > This provides reset driver support for the Microchip Sparx5 PCB134 and > PCB135 reference boards. This still looks like an incompatible change with no explanation. What happens on an old kernel that expects "microchip,sparx5-chip-reset" and doesn't understand "microchip,sparx5-switch-reset"? > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> > --- > arch/arm64/boot/dts/microchip/sparx5.dtsi | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi > index 380281f312d8..dc3ada5cf9fc 100644 > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > @@ -132,9 +132,12 @@ mux: mux-controller { > }; > }; > > - reset@611010008 { > - compatible = "microchip,sparx5-chip-reset"; > + reset: reset-controller@611010008 { > + compatible = "microchip,sparx5-switch-reset"; > reg = <0x6 0x11010008 0x4>; > + reg-names = "gcb"; > + #reset-cells = <1>; > + cpu-syscon = <&cpu_ctrl>; > }; > > uart0: serial@600100000 { > -- > 2.30.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver 2021-03-08 19:59 ` Rob Herring @ 2021-03-16 8:36 ` Steen Hegelund 0 siblings, 0 replies; 5+ messages in thread From: Steen Hegelund @ 2021-03-16 8:36 UTC (permalink / raw) To: Rob Herring Cc: Philipp Zabel, Andrew Lunn, Microchip Linux Driver Support, Alexandre Belloni, Gregory Clement, linux-kernel, linux-arm-kernel, devicetree Hi Rob, On Mon, 2021-03-08 at 12:59 -0700, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Wed, Mar 03, 2021 at 09:11:58AM +0100, Steen Hegelund wrote: > > This provides reset driver support for the Microchip Sparx5 PCB134 > > and > > PCB135 reference boards. > > This still looks like an incompatible change with no explanation. > > What happens on an old kernel that expects "microchip,sparx5-chip- > reset" > and doesn't understand "microchip,sparx5-switch-reset"? Sorry about forgetting that item. I will add a note to say that this is an incompatible change. In practice, I do not think the reset driver has really been taken into use yet. > > > > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> > > --- > > arch/arm64/boot/dts/microchip/sparx5.dtsi | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > index 380281f312d8..dc3ada5cf9fc 100644 > > --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi > > +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi > > @@ -132,9 +132,12 @@ mux: mux-controller { > > }; > > }; > > > > - reset@611010008 { > > - compatible = "microchip,sparx5-chip-reset"; > > + reset: reset-controller@611010008 { > > + compatible = "microchip,sparx5-switch-reset"; > > reg = <0x6 0x11010008 0x4>; > > + reg-names = "gcb"; > > + #reset-cells = <1>; > > + cpu-syscon = <&cpu_ctrl>; > > }; > > > > uart0: serial@600100000 { > > -- > > 2.30.1 > > -- BR Steen -=-=-=-=-=-=-=-=-=-=-=-=-=-= steen.hegelund@microchip.com ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-16 8:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210303081158.684532-1-steen.hegelund@microchip.com>
2021-03-03 8:11 ` [PATCH v7 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings Steen Hegelund
2021-03-03 8:11 ` [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver Steen Hegelund
2021-03-03 8:56 ` Alexandre Belloni
2021-03-08 19:59 ` Rob Herring
2021-03-16 8:36 ` Steen Hegelund
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).