* [PATCH] Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size"
@ 2021-05-29 13:02 Stefan Wahren
2021-06-08 10:06 ` nicolas saenz julienne
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Wahren @ 2021-05-29 13:02 UTC (permalink / raw)
To: Rob Herring, Nicolas Saenz Julienne
Cc: Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, devicetree, linux-rpi-kernel,
linux-arm-kernel, Stefan Wahren, Pavel Hofman
This reverts commit 278407a53c3b33fb820332c4d39eb39316c3879a.
The original change breaks USB config on Raspberry Pi Zero and Pi 4 B,
because it exceeds the total fifo size of 4080. A naive attempt to reduce
g-tx-fifo-size doesn't help on Raspberry Pi Zero. So better go back.
Fixes: 278407a53c3b ("ARM: dts: bcm283x: increase dwc2's RX FIFO size")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Pavel Hofman <pavel.hofman@ivitera.com>
---
arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi | 2 +-
arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi
index 20322de..e2fd961 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
&usb {
dr_mode = "otg";
- g-rx-fifo-size = <558>;
+ g-rx-fifo-size = <256>;
g-np-tx-fifo-size = <32>;
/*
* According to dwc2 the sum of all device EP
diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi
index 1409d1b..0ff0e9e 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
&usb {
dr_mode = "peripheral";
- g-rx-fifo-size = <558>;
+ g-rx-fifo-size = <256>;
g-np-tx-fifo-size = <32>;
g-tx-fifo-size = <256 256 512 512 512 768 768>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size"
2021-05-29 13:02 [PATCH] Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size" Stefan Wahren
@ 2021-06-08 10:06 ` nicolas saenz julienne
0 siblings, 0 replies; 2+ messages in thread
From: nicolas saenz julienne @ 2021-06-08 10:06 UTC (permalink / raw)
To: Stefan Wahren, Rob Herring
Cc: Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, devicetree, linux-rpi-kernel,
linux-arm-kernel, Pavel Hofman
On Sat, 2021-05-29 at 15:02 +0200, Stefan Wahren wrote:
> This reverts commit 278407a53c3b33fb820332c4d39eb39316c3879a.
>
> The original change breaks USB config on Raspberry Pi Zero and Pi 4 B,
> because it exceeds the total fifo size of 4080. A naive attempt to reduce
> g-tx-fifo-size doesn't help on Raspberry Pi Zero. So better go back.
>
> Fixes: 278407a53c3b ("ARM: dts: bcm283x: increase dwc2's RX FIFO size")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Cc: Pavel Hofman <pavel.hofman@ivitera.com>
> ---
Applied for next.
Regards,
Nicolas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-08 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-29 13:02 [PATCH] Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size" Stefan Wahren
2021-06-08 10:06 ` nicolas saenz julienne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).