From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B207EC6FD18 for ; Sat, 22 Apr 2023 14:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbjDVOwI (ORCPT ); Sat, 22 Apr 2023 10:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjDVOwH (ORCPT ); Sat, 22 Apr 2023 10:52:07 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B57331726 for ; Sat, 22 Apr 2023 07:52:05 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4ec8da7aaf8so2844745e87.2 for ; Sat, 22 Apr 2023 07:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682175124; x=1684767124; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ywAzN0uwbepU/kzWWxbD8/+wKk3qdyKFmWyIzqUzcGQ=; b=JFJkSdKtcHg59NvHIer99gkKAEicInvefBh6FZHy9yKQu1SenWhI66HF4xGkIUxm1Q Pkg5W6ri5pkEVPnCfDezi+wDbaRRtrEn4CKDtlAgHrYwC+GvgEhJghghVpX2YGRgLlkc lcm4wAxqDZKg3FUJeKCTA9DGAZeAQdSm/e/+1PwMtKoZsTjzW1RZQGZXuanLWDyJFyBR uJUjmI4MzdCbfcqion3yjOA2sI1aUHmkR0pSTSjHZBcj2qfFbyYozPzjKQ9cMz+tLvgN /5fWqTjgmeL8tVbIhJSUY6zepUm1LIFjJz/LuwVYYkaAg4bWRvF8v7fXFwnoFYF3zOcs aLuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682175124; x=1684767124; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ywAzN0uwbepU/kzWWxbD8/+wKk3qdyKFmWyIzqUzcGQ=; b=dlm7CEkvzC+fEUYX9mt4bPQDdYf7Qm/84N24kwjRpybAzAgTv4lx3fgQ2d5DyOz1jT k+6QQ17wXHvLaTR9uq5lEZ+206k33+T9s591qHCR4ZmikdDU6U5ggPZ1DhYIeEmxRHYr GS/MET2XWXn9ivajzBT+uf4j71bFEjxpejlakbLWGX7rdu2l1A6ghUnPBQU1EbLczp3Z 8pftI28qWMZY3QVhCGJSR4RNA9kmoEZ9RM7htSlAYzqiHoyNL9kfrJSYH6Eo+Ztt+JQy S/QCfQuEDUQEg/mjnMppBnmU0tYYJjLuln/BTOaAQ6mUF/I/zz0HykdDfdym6e9rSwU4 lReg== X-Gm-Message-State: AAQBX9eWvbJgGnYRiDleT3ga2fxZEmhBftC2xPp5bHQigkCLSSxfRQBi wkVdrxQU28hUIzqCdePx1cf6YA== X-Google-Smtp-Source: AKy350Yy9He00JyxJYgCrhoncnpgPUu+lmynJn6gPzpunftRFikNXDR8nvbg2gAzLONeNNn+6T+e3Q== X-Received: by 2002:ac2:490e:0:b0:4d7:59e6:388e with SMTP id n14-20020ac2490e000000b004d759e6388emr1973780lfi.46.1682175123979; Sat, 22 Apr 2023 07:52:03 -0700 (PDT) Received: from [192.168.1.101] (abyj144.neoplus.adsl.tpnet.pl. [83.9.29.144]) by smtp.gmail.com with ESMTPSA id q2-20020ac25a02000000b004b4cbc942a3sm923986lfn.127.2023.04.22.07.52.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Apr 2023 07:52:03 -0700 (PDT) Message-ID: <31bf025d-decf-c30c-8ffe-7e935bb31790@linaro.org> Date: Sat, 22 Apr 2023 16:52:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v5 11/14] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Content-Language: en-US To: Bryan O'Donoghue , linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: caleb.connolly@linaro.org, subbaram@quicinc.com, jackp@quicinc.com, robertom@qti.qualcomm.com References: <20230413113438.1577658-1-bryan.odonoghue@linaro.org> <20230413113438.1577658-12-bryan.odonoghue@linaro.org> From: Konrad Dybcio In-Reply-To: <20230413113438.1577658-12-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13.04.2023 13:34, Bryan O'Donoghue wrote: > Switch on usb-role-switching for usb_1 via TCPM. We need to declare > usb-role-switch in &usb_1 and associate with the remote-endpoint in TCPM > which provides the necessary signal. > > Signed-off-by: Bryan O'Donoghue > --- This belongs to the SoC DTSI as it describes the capabilities of the USB controllers on the chip. Also please add a newline before each subnode. Konrad > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index 1e0b6fd59abc9..b5cc45358a474 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -1273,7 +1273,13 @@ &usb_1 { > }; > > &usb_1_dwc3 { > - dr_mode = "peripheral"; > + dr_mode = "otg"; > + usb-role-switch; > + port { > + dwc3_role_switch_in: endpoint { > + remote-endpoint = <&pm8150b_role_switch_out>; > + }; > + }; > }; > > &usb_1_hsphy { > @@ -1359,5 +1365,16 @@ connector { > PDO_FIXED_DUAL_ROLE | > PDO_FIXED_USB_COMM | > PDO_FIXED_DATA_SWAP)>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + pm8150b_role_switch_out: endpoint { > + remote-endpoint = <&dwc3_role_switch_in>; > + }; > + }; > + }; > }; > };