From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH] dt-bindings: leds: lp50xx: fix LED children names
Date: Fri, 24 Jun 2022 19:31:18 +0200 [thread overview]
Message-ID: <31f5f441-eba3-4ffb-cf68-159cd827ade7@linaro.org> (raw)
In-Reply-To: <1656091594.405509.146345.nullmailer@robh.at.kernel.org>
On 24/06/2022 19:26, Rob Herring wrote:
> On Fri, 24 Jun 2022 13:13:25 +0200, Krzysztof Kozlowski wrote:
>> The lp50xx LEDs expects to have single-color LED children with unit
>> addresses. This is required by the driver and provided by existing
>> DTSes. Fix the binding to match actual usage.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers")
>> ---
>> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.example.dtb: led-controller@14: multi-led@2:#size-cells:0:0: 0 was expected
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>
This is expected and fixed in:
https://lore.kernel.org/all/20220607075247.58048-1-krzysztof.kozlowski@linaro.org/
I did not combine this patch with above patchset because this one is a
fix and might be backported to stable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-24 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 11:13 [PATCH] dt-bindings: leds: lp50xx: fix LED children names Krzysztof Kozlowski
2022-06-24 17:26 ` Rob Herring
2022-06-24 17:31 ` Krzysztof Kozlowski [this message]
2022-07-05 12:13 ` Krzysztof Kozlowski
2022-06-27 19:14 ` Rob Herring
2022-07-17 12:50 ` Pavel Machek
2022-07-18 15:18 ` Rob Herring
2022-07-19 7:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31f5f441-eba3-4ffb-cf68-159cd827ade7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).