From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F979EE49AC for ; Sat, 19 Aug 2023 10:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230164AbjHSKkS (ORCPT ); Sat, 19 Aug 2023 06:40:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbjHSKkM (ORCPT ); Sat, 19 Aug 2023 06:40:12 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD35F9EBB for ; Sat, 19 Aug 2023 02:35:38 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5231410ab27so2177147a12.0 for ; Sat, 19 Aug 2023 02:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692437737; x=1693042537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MXy3bc3W8hEI+d10Tnd1Q43Jc8SX1WBV0Tg2c/cXUNI=; b=GL9pfjsFCRAnfAYcBbZezhb/E8MaAs/kNZ8cVRiQrprHhooyTfujR34lE4GA2Hts57 NkCEXlfWS/8BNFrePFUq5kT23ROVx6zaRCvhOLSzhdslgjJhDYadCecws486JYq3vwQH qL0jU+rzQQXrdsux5sSh0AWRVI+Bw6t/114J79E6mCZhNRonzso+sP+tQRwIpE+dLIly zinF80DUmCwSY5yygMLQwFcOm+fQhWIyO3eWGjAdnRi4R7LjlIrt2e53IO8YmOxDEFIf c85mLihAN02R652xLHm4yBn5AfB6H1kEC8Fv4IbyRqhu1Pucsq1p/Vn/ZRJ/hQgtZG3x B53w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692437737; x=1693042537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MXy3bc3W8hEI+d10Tnd1Q43Jc8SX1WBV0Tg2c/cXUNI=; b=eE9Zu3FijnjNPqnsBp5GAV3T4RvvRpBjP5SyeC451y0OgUro5b4O6UT/2ELwzXdIzF HpmEYLbmiXKZSf+dNsdqNrFRW1Z17GPejzgKIiPK/lqUixrHDuARRqSJho3jUhjue4XA 4pQCIE5uT5WgdIbR3RWqVNhTLb1aFfmTY2giGuscgdYO1s7ogqe+qv9YNqgNE8I8m2oN 3Pbix+U+WMKzVSwzznDsMxifbjF4aG75rn3PjyZaBIdgmGiu6VfPZROykwWvBJjj//oK 1J5aQGhiR0ia65D6Sl2QkVBigyJS/18qQtk/3LaZw1OAKA5JSkuScyrowaYSkFldR5eS r76w== X-Gm-Message-State: AOJu0YzStBfBZCrafTI0s6DVpPYY9N4B8VtNMVAVqByLiJ1OaerUvYmP qUTfF+XuLyEGmrmoe0QZJCaGivZ1e6QqJm5gIa4= X-Google-Smtp-Source: AGHT+IHkoZRCadlwhyz7BaGiI6cguuY739O4FS480p+P7ndaptyPyw7BgT+jRx8SXjB47ckHVQXHtA== X-Received: by 2002:a17:906:217:b0:993:fe68:569d with SMTP id 23-20020a170906021700b00993fe68569dmr1270933ejd.17.1692437737012; Sat, 19 Aug 2023 02:35:37 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id yy10-20020a170906dc0a00b0099d02ca4327sm2386605ejb.54.2023.08.19.02.35.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Aug 2023 02:35:36 -0700 (PDT) Message-ID: <31fa930a-51fb-6a7f-300d-e71f6b399eb1@linaro.org> Date: Sat, 19 Aug 2023 11:35:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 2/3] dt-bindings: usb: snps,dwc3: Add runtime-suspend-on-usb-suspend property To: Elson Serrao , gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com, rogerq@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20230814185043.9252-1-quic_eserrao@quicinc.com> <20230814185043.9252-3-quic_eserrao@quicinc.com> <6b27cd55-4e44-7a26-30ff-9692344cae4c@quicinc.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <6b27cd55-4e44-7a26-30ff-9692344cae4c@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/08/2023 21:16, Elson Serrao wrote: > > > On 8/15/2023 10:44 PM, Krzysztof Kozlowski wrote: >> On 14/08/2023 20:50, Elson Roy Serrao wrote: >>> This property allows dwc3 runtime suspend when bus suspend interrupt >>> is received even with cable connected. This would allow the dwc3 >>> controller to enter low power mode during bus suspend scenario. >>> >>> This property would particularly benefit dwc3 IPs where hibernation is >>> not enabled and the dwc3 low power mode entry/exit is handled by the >>> glue driver. The assumption here is that the platform using this dt >>> property is capable of detecting resume events to bring the controller >>> out of suspend. >>> >>> Signed-off-by: Elson Roy Serrao >>> --- >>> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>> index a696f23730d3..e19a60d06d2b 100644 >>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>> @@ -403,6 +403,11 @@ properties: >>> description: >>> Enable USB remote wakeup. >>> >>> + snps,runtime-suspend-on-usb-suspend: >>> + description: >>> + If True then dwc3 runtime suspend is allowed during bus suspend >>> + case even with the USB cable connected. >> >> This was no tested... but anyway, this is no a DT property but OS >> policy. There is no such thing as "runtime suspend" in the hardware, >> because you describe one particular OS. >> >> Sorry, no a DT property, drop the change entirely. >> >> > Hi Krzysztof > > Sorry my local dt checker had some issue and it did not catch these > errors. I have rectified it now. > > This dt property is mainly for skipping dwc3 controller halt when a USB > suspend interrupt is received with usb cable connected, so that we dont > trigger a DISCONNECT event. Perhaps a better name would reflect the true > usage of this? > > Something like snps,skip-dwc3-halt-on-usb-suspend. dwc3 cores where > hibernation feature is not enabled/supported can use this property So this is specific to DWC3 core, thus should be just implied by compatible. Best regards, Krzysztof