Re: [v2 02/10] dts-bingings: display: bridge: Add MHDP HDMI bindings for i.MX8MQ

Krzysztof Kozlowski
2022-11-04T13:42:14Z

On 04/11/2022 02:44, Sandor Yu wrote:
> Add bindings for i.MX8MQ MHDP HDMI.

Typo in subject - bindings.

Also in the subject - drop redundant second word "bindings".

>
> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com>
> ---
> .../display/bridge/cdns,mhdp-imx8mq-hdmi.yaml | 67 +++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
> new file mode 100644
> index 000000000000..b2a769d4cb82
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Cadence MHDP HDMI bridge
> +
> +maintainers:
> + - Sandor Yu <Sandor.yu@nxp.com>
> +
> +description:
> + The Cadence MHDP TX HDMI interface.
> +
> +properties:
> + compatible:
> + enum:
> + - cdns,mhdp-imx8mq-hdmi
> +
> + reg:
> + items:
> + - description:
> + Memory mapped base address and length of mhdptx apb registers.

Drop items and descripion and just "maxItems: 1"

> +
> + phys:
> + description:
> + phandle to the HDMI PHY.

Drop description, but instead "maxItems: 1"

> +
> + phy-names:
> + items:
> + - const: hdmiphy

Drop entire phy-names, not useful with one entry matching the name of
theh block.

> +
> + interrupts:
> + items:
> + - description: Hotplug detect interrupter for cable plugin event.
> + - description: Hotplug detect interrupter for cable plugout event.
> +
> + interrupt-names:
> + items:
> + - const: plug_in
> + - const: plug_out
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + A port node pointing to the output port of a display controller..

Just one '.' at the end.

> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mhdp: mhdp@32c00000 {

Node names should be generic, so hdmi-bridge, display-controller or just
"hdmi"
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> + compatible = "cdns,mhdp-imx8mq-hdmi";
> + reg = <0x32c00000 0x100000>;

Best regards,
Krzysztof