From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFC4C4708D for ; Mon, 12 Dec 2022 02:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230462AbiLLCqn (ORCPT ); Sun, 11 Dec 2022 21:46:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230457AbiLLCqm (ORCPT ); Sun, 11 Dec 2022 21:46:42 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C53055BA; Sun, 11 Dec 2022 18:46:37 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id CA32F24E0D6; Mon, 12 Dec 2022 10:46:28 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 12 Dec 2022 10:46:28 +0800 Received: from [192.168.125.96] (113.72.147.126) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 12 Dec 2022 10:46:28 +0800 Message-ID: <320c8cd8-ef52-77ac-45a8-3b4a800c009d@starfivetech.com> Date: Mon, 12 Dec 2022 10:46:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RESEND PATCH v2 1/3] dt-bindings: power: Add starfive,jh71xx-pmu To: Krzysztof Kozlowski , , , CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , "Rafael J . Wysocki" , References: <20221208084523.9733-1-walker.chen@starfivetech.com> <20221208084523.9733-2-walker.chen@starfivetech.com> Content-Language: en-US From: Walker Chen In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.147.126] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022/12/8 16:59, Krzysztof Kozlowski wrote: > On 08/12/2022 09:45, Walker Chen wrote: >> Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. >> >> Signed-off-by: Walker Chen >> --- >> .../bindings/power/starfive,jh71xx-pmu.yaml | 45 +++++++++++++++++++ >> .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ >> 2 files changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > > Filename matching compatible, so: > starfive,jh7110-pmu.yaml OK, will be fixed. > > >> create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h >> >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml >> new file mode 100644 >> index 000000000000..f308ae136a57 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/starfive,jh71xx-pmu.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH71xx Power Management Unit >> + >> +maintainers: >> + - Walker Chen >> + >> +description: | >> + StarFive JH71xx SoCs include support for multiple power domains which can be >> + powered on/off by software based on different application scenes to save power. >> + >> +properties: >> + compatible: >> + - enum: > > Wrong indentation. > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). This is my mistake, I forgot to make dt_binding_check for .yaml file. > >> + - starfive,jh7110-pmu >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + "#power-domain-cells": >> + const: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - "#power-domain-cells" >> + > > Best regards, > Krzysztof >