From: neil.armstrong@linaro.org
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: qcom: sm8550-mtp: correct WCD9385 TX port mapping
Date: Thu, 25 Jan 2024 14:02:28 +0100 [thread overview]
Message-ID: <320eeed2-af8c-4a83-b0d6-301ceb74f532@linaro.org> (raw)
In-Reply-To: <8819b406-34a4-48ba-8d69-25cb4cbcf3e1@linaro.org>
On 25/01/2024 11:47, Konrad Dybcio wrote:
>
>
> On 1/25/24 11:43, Krzysztof Kozlowski wrote:
>> On 25/01/2024 10:59, Konrad Dybcio wrote:
>>>
>>>
>>> On 1/24/24 17:45, Krzysztof Kozlowski wrote:
>>>> WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact
>>>> it is offset by one. Correct it to fix recording via analogue
>>>> microphones.
>>>>
>>>> The change is based on QRD8550 and should be correct here as well, but
>>>> was not tested on MTP8550.
>>>
>>> Would this not be codec-and-not-board-specific, anyway?
>>
>> Yes, indeed, it should be.
>
> Should we move this to the driver and drop the then-uselesss
> dt property?
Actually it's codec-and-soc specific, so I'm against dropping this.
On the sc8280xp & sc7280 it requires a different mapping because the
TX macro changed the way to map the soundwire channels since (at least) SM8450.
Neil
>
> Konrad
>
next prev parent reply other threads:[~2024-01-25 13:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 16:45 [PATCH 1/4] arm64: dts: qcom: sm8550-qrd: correct WCD9385 TX port mapping Krzysztof Kozlowski
2024-01-24 16:45 ` [PATCH 2/4] arm64: dts: qcom: sm8550-mtp: " Krzysztof Kozlowski
2024-01-24 16:56 ` neil.armstrong
2024-01-25 9:59 ` Konrad Dybcio
2024-01-25 10:43 ` Krzysztof Kozlowski
2024-01-25 10:47 ` Konrad Dybcio
2024-01-25 13:02 ` neil.armstrong [this message]
2024-01-25 16:14 ` Konrad Dybcio
2024-01-24 16:45 ` [PATCH 3/4] arm64: dts: qcom: sm8550-qrd: add correct analogue microphones Krzysztof Kozlowski
2024-01-24 16:45 ` [PATCH 4/4] arm64: dts: qcom: sm8550-mtp: " Krzysztof Kozlowski
2024-01-25 9:58 ` [PATCH 1/4] arm64: dts: qcom: sm8550-qrd: correct WCD9385 TX port mapping Konrad Dybcio
2024-02-07 4:46 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=320eeed2-af8c-4a83-b0d6-301ceb74f532@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).